From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2191C43381 for ; Thu, 21 Mar 2019 14:01:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8DC632183E for ; Thu, 21 Mar 2019 14:01:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NzWesO9a" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728049AbfCUOB0 (ORCPT ); Thu, 21 Mar 2019 10:01:26 -0400 Received: from mail-ed1-f68.google.com ([209.85.208.68]:38542 "EHLO mail-ed1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727829AbfCUOB0 (ORCPT ); Thu, 21 Mar 2019 10:01:26 -0400 Received: by mail-ed1-f68.google.com with SMTP id q14so5095502edr.5 for ; Thu, 21 Mar 2019 07:01:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hlxbjYsUs6XX119SD/D7FRvgXPfsCoEE76Ix371ev9w=; b=NzWesO9aKhXPJK6KobVfGDo9IepfW6Xeh/eDKVdsVhvLiRExJ5Am6rNDxR0E3N5Mtp XufJJCMip5lKqkFVyFpiRsl1kA44Pll+ONRWr8mjtDtzS1EgWSQmH1eXKmpW3v3T9O/R MyWIxacN7GjeIeszLGyKtAnxXoBj221tMreQ9VLWyPVoLlP4wnqqtVozrg5PBfHuOXnv U/9/v7+GvqyWEKgMEx4jBH/aasLUoWVZlyz3otm9xzVmGkh/C/RCQuyScqXfo4WCbp83 LHloDRi3S7bsBs1rtT/vKo0t+O2aBqbuVbqmF4aIDYPRIFsLAGvAYMyINe3BmbkxDUUf Wi1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hlxbjYsUs6XX119SD/D7FRvgXPfsCoEE76Ix371ev9w=; b=eul9pDHr6HBHz8N0OScRF26meJxco6fnPZ8cg02a7IL4GvdGQ9Lfto4PTgqolMRYyB GeXxMX7jUS5oJG+SJyYoENGPMjFbAVSilBaHDOM4jOT6zOS2oqy/I7OuQAoI1rqeks8I k/bghOjYsQWT0gDomorwjtfeXCJ6g4DxkGLiaNvx4JJDZia9U1qP4vNrUYjEbH5XNWrN cXF3aeBYXc0gkBSyzW4GfyeeZC5v5Ko65KNHbPVnxbQW1HlxhtD+k9DHl2Ei9rwo3LjJ +6pQNM0/d/1zlzBPDsh0dd15Dsow3EuxZcEYyt2LMPj1a824/ZVV6AJr9hY4NFKegSdD GZ1Q== X-Gm-Message-State: APjAAAVPy3RLAjbtaHn/icsCDHt28h/FmFAeajHtdE4nboZsyP79EWq7 7WeFghcFV4TV1byRtaWrv7QfUO1cA7GeJy2UcxU= X-Google-Smtp-Source: APXvYqyvEzHJZw4/o1lY6OoU+Gv0aPRpeS2dXrjAN/BTqLtalyAnDt2AU5rCq4dD1USY3eWgEOYXMTIVjPC9x8uicSg= X-Received: by 2002:a50:f286:: with SMTP id f6mr2609792edm.139.1553176884306; Thu, 21 Mar 2019 07:01:24 -0700 (PDT) MIME-Version: 1.0 References: <20190320144944.147862-1-willemdebruijn.kernel@gmail.com> <20190320144944.147862-9-willemdebruijn.kernel@gmail.com> In-Reply-To: From: Willem de Bruijn Date: Thu, 21 Mar 2019 10:00:48 -0400 Message-ID: Subject: Re: [PATCH bpf-next 08/13] bpf: add bpf_skb_adjust_room flag BPF_F_ADJ_ROOM_FIXED_GSO To: Alan Maguire Cc: Network Development , Alexei Starovoitov , Daniel Borkmann , Stanislav Fomichev , Peter Oskolkov , Willem de Bruijn Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Mar 21, 2019 at 9:43 AM Alan Maguire wrote: > > > > On Wed, 20 Mar 2019, Willem de Bruijn wrote: > > > From: Willem de Bruijn > > > > bpf_skb_adjust_room adjusts gso_size of gso packets to account for the > > pushed or popped header room. > > > > This is not allowed with UDP, where gso_size delineates datagrams. Add > > an option to avoid these updates and allow this call for datagrams. > > > > It can also be used with TCP, when MSS is known to allow headroom, > > e.g., through MSS clamping or route MTU. > > > > Link: https://patchwork.ozlabs.org/patch/1052497/ > > Signed-off-by: Willem de Bruijn > > --- > > include/uapi/linux/bpf.h | 4 ++++ > > net/core/filter.c | 36 +++++++++++++++++++++++++----------- > > 2 files changed, 29 insertions(+), 11 deletions(-) > > > > diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h > > index 4f5c918e6fcf4..0eda8f564a381 100644 > > --- a/include/uapi/linux/bpf.h > > +++ b/include/uapi/linux/bpf.h > > @@ -2593,6 +2593,10 @@ enum bpf_func_id { > > /* Current network namespace */ > > #define BPF_F_CURRENT_NETNS (-1L) > > > > +/* BPF_FUNC_skb_adjust_room flags. */ > > +#define BPF_F_ADJ_ROOM_FIXED_GSO (1ULL << 0) > > minor nit - could we add this flag to the documentation for > bpf_skb_adjust_room? Same suggestion for the encap flags in > patch 8 too. Thanks! > > Reviewed-by: Alan Maguire Definitely, will do in v2. Thanks.