From: Loic Poulain <loic.poulain@oss.qualcomm.com>
To: Sergey Ryazanov <ryazanov.s.a@gmail.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Eric Dumazet <edumazet@google.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, Slark Xiao <slark_xiao@163.com>,
Muhammad Nuzaihan <zaihan@unrealasia.net>,
Qiang Yu <quic_qianyu@quicinc.com>,
Manivannan Sadhasivam <mani@kernel.org>,
Johan Hovold <johan@kernel.org>
Subject: Re: [RFC PATCH v2 0/6] net: wwan: add NMEA port type support
Date: Sun, 29 Jun 2025 04:50:18 +0200 [thread overview]
Message-ID: <CAFEp6-08JX1gDDn2-hP5AjXHCGsPYHe05FscQoyiP_OaSQfzqQ@mail.gmail.com> (raw)
In-Reply-To: <20250624213801.31702-1-ryazanov.s.a@gmail.com>
Hi Sergey,
On Tue, Jun 24, 2025 at 11:39 PM Sergey Ryazanov <ryazanov.s.a@gmail.com> wrote:
>
> The series introduces a long discussed NMEA port type support for the
> WWAN subsystem. There are two goals. From the WWAN driver perspective,
> NMEA exported as any other port type (e.g. AT, MBIM, QMI, etc.). From
> user space software perspective, the exported chardev belongs to the
> GNSS class what makes it easy to distinguish desired port and the WWAN
> device common to both NMEA and control (AT, MBIM, etc.) ports makes it
> easy to locate a control port for the GNSS receiver activation.
>
> Done by exporting the NMEA port via the GNSS subsystem with the WWAN
> core acting as proxy between the WWAN modem driver and the GNSS
> subsystem.
>
> The series starts from a cleanup patch. Then two patches prepares the
> WWAN core for the proxy style operation. Followed by a patch introding a
> new WWNA port type, integration with the GNSS subsystem and demux. The
> series ends with a couple of patches that introduce emulated EMEA port
> to the WWAN HW simulator.
>
> The series is the product of the discussion with Loic about the pros and
> cons of possible models and implementation. Also Muhammad and Slark did
> a great job defining the problem, sharing the code and pushing me to
> finish the implementation. Many thanks.
>
> Comments are welcomed.
>
> Slark, Muhammad, if this series suits you, feel free to bundle it with
> the driver changes and (re-)send for final inclusion as a single series.
>
> Changes RFCv1->RFCv2:
> * Uniformly use put_device() to release port memory. This made code less
> weird and way more clear. Thank you, Loic, for noticing and the fix
> discussion!
I think you can now send that series without the RFC tag. It looks good to me.
next prev parent reply other threads:[~2025-06-29 2:50 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-24 21:37 [RFC PATCH v2 0/6] net: wwan: add NMEA port type support Sergey Ryazanov
2025-06-24 21:37 ` [RFC PATCH v2 1/6] net: wwan: core: remove unused port_id field Sergey Ryazanov
2025-06-24 21:37 ` [RFC PATCH v2 2/6] net: wwan: core: split port creation and registration Sergey Ryazanov
2025-06-24 21:37 ` [RFC PATCH v2 3/6] net: wwan: core: split port unregister and stop Sergey Ryazanov
2025-06-24 21:37 ` [RFC PATCH v2 4/6] net: wwan: add NMEA port support Sergey Ryazanov
2025-06-24 21:38 ` [RFC PATCH v2 5/6] net: wwan: hwsim: refactor to support more port types Sergey Ryazanov
2025-06-24 21:38 ` [RFC PATCH v2 6/6] net: wwan: hwsim: support NMEA port emulation Sergey Ryazanov
2025-06-29 2:50 ` Loic Poulain [this message]
2025-06-29 10:07 ` [RFC PATCH v2 0/6] net: wwan: add NMEA port type support Sergey Ryazanov
2025-06-30 7:30 ` Loic Poulain
2025-09-11 2:42 ` Slark Xiao
2025-09-14 16:43 ` Sergey Ryazanov
2025-09-16 7:23 ` Slark Xiao
2025-09-22 8:03 ` Loic Poulain
2025-09-22 20:19 ` Daniele Palmas
2025-09-30 7:10 ` Daniele Palmas
2025-10-02 15:44 ` Loic Poulain
2025-10-08 21:01 ` Sergey Ryazanov
2025-10-10 13:47 ` Daniele Palmas
2025-10-12 22:55 ` Sergey Ryazanov
2025-11-14 7:08 ` Slark Xiao
2025-11-19 11:27 ` Loic Poulain
2025-11-24 6:57 ` Slark Xiao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEp6-08JX1gDDn2-hP5AjXHCGsPYHe05FscQoyiP_OaSQfzqQ@mail.gmail.com \
--to=loic.poulain@oss.qualcomm.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=johan@kernel.org \
--cc=johannes@sipsolutions.net \
--cc=kuba@kernel.org \
--cc=mani@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=quic_qianyu@quicinc.com \
--cc=ryazanov.s.a@gmail.com \
--cc=slark_xiao@163.com \
--cc=zaihan@unrealasia.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).