[REGRESSION] stmmac_platform: Unknown symbol devm_kmalloc (err 0)

[REGRESSION] stmmac_platform: Unknown symbol devm_kmalloc (err 0)

[Igor Gnatenko]

Hi all, stmmac driver doesn't work on cubietruck (and some more
devices like PcDuino3 Nano[0]).

This error comes from converting dwmac-sunxi to platform driver.

stmmac_platform: module license 'unspecified' taints kernel.
Disabling lock debugging due to kernel taint
stmmac_platform: Unknown symbol devm_kmalloc (err 0)
stmmac_platform: Unknown symbol stmmac_suspend (err 0)
stmmac_platform: Unknown symbol platform_get_irq_byname (err 0)
stmmac_platform: Unknown symbol stmmac_dvr_remove (err 0)
stmmac_platform: Unknown symbol platform_get_resource (err 0)
stmmac_platform: Unknown symbol of_get_phy_mode (err 0)
stmmac_platform: Unknown symbol of_property_read_u32_array (err 0)
stmmac_platform: Unknown symbol of_alias_get_id (err 0)
stmmac_platform: Unknown symbol stmmac_resume (err 0)
stmmac_platform: Unknown symbol stmmac_dvr_probe (err 0)

I've filled bugreport with the same info[1]. What info I would provide
to help with fixing this?

[0] https://lists.fedoraproject.org/pipermail/arm/2015-July/009681.html
[1] https://bugzilla.kernel.org/show_bug.cgi?id=102141
-- 
-Igor Gnatenko

Re: [REGRESSION] stmmac_platform: Unknown symbol devm_kmalloc (err 0)

[Joachim Eastwood]

Hi Igor,

On 31 July 2015 at 01:07, Igor Gnatenko <i.gnatenko.brain@gmail.com> wrote:
> Hi all, stmmac driver doesn't work on cubietruck (and some more
> devices like PcDuino3 Nano[0]).
>
> This error comes from converting dwmac-sunxi to platform driver.
>
> stmmac_platform: module license 'unspecified' taints kernel.
> Disabling lock debugging due to kernel taint

Ah, I guess 50649ab14982a ("stmmac: drop driver from stmmac platform
code") was a over eager when removing stuff. I should have kept the
MODULE_* macro's as stmmac_platform can still be a module. I'll send
out a patch a bit later with a CC to you.


> stmmac_platform: Unknown symbol devm_kmalloc (err 0)
> stmmac_platform: Unknown symbol stmmac_suspend (err 0)
> stmmac_platform: Unknown symbol platform_get_irq_byname (err 0)
> stmmac_platform: Unknown symbol stmmac_dvr_remove (err 0)
> stmmac_platform: Unknown symbol platform_get_resource (err 0)
> stmmac_platform: Unknown symbol of_get_phy_mode (err 0)
> stmmac_platform: Unknown symbol of_property_read_u32_array (err 0)
> stmmac_platform: Unknown symbol of_alias_get_id (err 0)
> stmmac_platform: Unknown symbol stmmac_resume (err 0)
> stmmac_platform: Unknown symbol stmmac_dvr_probe (err 0)

I'll look into this as well.


> I've filled bugreport with the same info[1]. What info I would provide
> to help with fixing this?

Thanks for reporting. If you could test patch I will send out soon
that would be of great help.


regards,
Joachim Eastwood

> [0] https://lists.fedoraproject.org/pipermail/arm/2015-July/009681.html
> [1] https://bugzilla.kernel.org/show_bug.cgi?id=102141
> --
> -Igor Gnatenko
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [REGRESSION] stmmac_platform: Unknown symbol devm_kmalloc (err 0)

[Igor Gnatenko]

On Fri, Jul 31, 2015 at 5:02 PM, Joachim  Eastwood <manabian@gmail.com> wrote:
> Hi Igor,
Hi,
>
> On 31 July 2015 at 01:07, Igor Gnatenko <i.gnatenko.brain@gmail.com> wrote:
>> Hi all, stmmac driver doesn't work on cubietruck (and some more
>> devices like PcDuino3 Nano[0]).
>>
>> This error comes from converting dwmac-sunxi to platform driver.
>>
>> stmmac_platform: module license 'unspecified' taints kernel.
>> Disabling lock debugging due to kernel taint
>
> Ah, I guess 50649ab14982a ("stmmac: drop driver from stmmac platform
> code") was a over eager when removing stuff. I should have kept the
> MODULE_* macro's as stmmac_platform can still be a module. I'll send
> out a patch a bit later with a CC to you.
Cool!
>
>
>> stmmac_platform: Unknown symbol devm_kmalloc (err 0)
>> stmmac_platform: Unknown symbol stmmac_suspend (err 0)
>> stmmac_platform: Unknown symbol platform_get_irq_byname (err 0)
>> stmmac_platform: Unknown symbol stmmac_dvr_remove (err 0)
>> stmmac_platform: Unknown symbol platform_get_resource (err 0)
>> stmmac_platform: Unknown symbol of_get_phy_mode (err 0)
>> stmmac_platform: Unknown symbol of_property_read_u32_array (err 0)
>> stmmac_platform: Unknown symbol of_alias_get_id (err 0)
>> stmmac_platform: Unknown symbol stmmac_resume (err 0)
>> stmmac_platform: Unknown symbol stmmac_dvr_probe (err 0)
>
> I'll look into this as well.
>
>
>> I've filled bugreport with the same info[1]. What info I would provide
>> to help with fixing this?
>
> Thanks for reporting. If you could test patch I will send out soon
> that would be of great help.
I will test patch ASAP once I will get it into my mailbox.
>
>
> regards,
> Joachim Eastwood
>
>> [0] https://lists.fedoraproject.org/pipermail/arm/2015-July/009681.html
>> [1] https://bugzilla.kernel.org/show_bug.cgi?id=102141
>> --
>> -Igor Gnatenko
-- 
-Igor Gnatenko

[PATCH net] stmmac: fix missing MODULE_LICENSE in stmmac_platform

[Joachim Eastwood]

Commit 50649ab14982 ("stmmac: drop driver from stmmac platform code")
was a bit overzealous in removing code and dropped the MODULE_*
macro's that are still needed since stmmac_platform can be a module.
Fix this by putting the macro's remvoed in 50649ab14982 back.

This fixes the following errors when used as a module:
  stmmac_platform: module license 'unspecified' taints kernel.
  Disabling lock debugging due to kernel taint
  stmmac_platform: Unknown symbol devm_kmalloc (err 0)
  stmmac_platform: Unknown symbol stmmac_suspend (err 0)
  stmmac_platform: Unknown symbol platform_get_irq_byname (err 0)
  stmmac_platform: Unknown symbol stmmac_dvr_remove (err 0)
  stmmac_platform: Unknown symbol platform_get_resource (err 0)
  stmmac_platform: Unknown symbol of_get_phy_mode (err 0)
  stmmac_platform: Unknown symbol of_property_read_u32_array (err 0)
  stmmac_platform: Unknown symbol of_alias_get_id (err 0)
  stmmac_platform: Unknown symbol stmmac_resume (err 0)
  stmmac_platform: Unknown symbol stmmac_dvr_probe (err 0)

Fixes: 50649ab14982 ("stmmac: drop driver from stmmac platform code")
Reported-by: Igor Gnatenko <i.gnatenko.brain@gmail.com>
Signed-off-by: Joachim Eastwood <manabian@gmail.com>
---
Hi,

An alternative solution could be to change CONFIG_STMMAC_PLATFORM
into a bool, but I guess we want to keep things as modular as
possible.

Please test this Igor and report back. Thanks!

 drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
index f3918c7e7eeb..bcdc8955c719 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
@@ -413,3 +413,7 @@ static int stmmac_pltfr_resume(struct device *dev)
 SIMPLE_DEV_PM_OPS(stmmac_pltfr_pm_ops, stmmac_pltfr_suspend,
 				       stmmac_pltfr_resume);
 EXPORT_SYMBOL_GPL(stmmac_pltfr_pm_ops);
+
+MODULE_DESCRIPTION("STMMAC 10/100/1000 Ethernet platform support");
+MODULE_AUTHOR("Giuseppe Cavallaro <peppe.cavallaro@st.com>");
+MODULE_LICENSE("GPL");
-- 
1.8.0

Re: [PATCH net] stmmac: fix missing MODULE_LICENSE in stmmac_platform

[David Miller]

From: Joachim Eastwood <manabian@gmail.com>
Date: Fri, 31 Jul 2015 19:02:32 +0200

> Commit 50649ab14982 ("stmmac: drop driver from stmmac platform code")
> was a bit overzealous in removing code and dropped the MODULE_*
> macro's that are still needed since stmmac_platform can be a module.
> Fix this by putting the macro's remvoed in 50649ab14982 back.
> 
> This fixes the following errors when used as a module:
>   stmmac_platform: module license 'unspecified' taints kernel.
>   Disabling lock debugging due to kernel taint
>   stmmac_platform: Unknown symbol devm_kmalloc (err 0)
>   stmmac_platform: Unknown symbol stmmac_suspend (err 0)
>   stmmac_platform: Unknown symbol platform_get_irq_byname (err 0)
>   stmmac_platform: Unknown symbol stmmac_dvr_remove (err 0)
>   stmmac_platform: Unknown symbol platform_get_resource (err 0)
>   stmmac_platform: Unknown symbol of_get_phy_mode (err 0)
>   stmmac_platform: Unknown symbol of_property_read_u32_array (err 0)
>   stmmac_platform: Unknown symbol of_alias_get_id (err 0)
>   stmmac_platform: Unknown symbol stmmac_resume (err 0)
>   stmmac_platform: Unknown symbol stmmac_dvr_probe (err 0)
> 
> Fixes: 50649ab14982 ("stmmac: drop driver from stmmac platform code")
> Reported-by: Igor Gnatenko <i.gnatenko.brain@gmail.com>
> Signed-off-by: Joachim Eastwood <manabian@gmail.com>

Applied, thanks.

[PATCH RESEND net] stmmac: fix missing MODULE_LICENSE in stmmac_platform

[Joachim Eastwood]

Commit 50649ab14982 ("stmmac: drop driver from stmmac platform code")
was a bit overzealous in removing code and dropped the MODULE_*
macro's that are still needed since stmmac_platform can be a module.
Fix this by putting the macro's remvoed in 50649ab14982 back.

This fixes the following errors when used as a module:
  stmmac_platform: module license 'unspecified' taints kernel.
  Disabling lock debugging due to kernel taint
  stmmac_platform: Unknown symbol devm_kmalloc (err 0)
  stmmac_platform: Unknown symbol stmmac_suspend (err 0)
  stmmac_platform: Unknown symbol platform_get_irq_byname (err 0)
  stmmac_platform: Unknown symbol stmmac_dvr_remove (err 0)
  stmmac_platform: Unknown symbol platform_get_resource (err 0)
  stmmac_platform: Unknown symbol of_get_phy_mode (err 0)
  stmmac_platform: Unknown symbol of_property_read_u32_array (err 0)
  stmmac_platform: Unknown symbol of_alias_get_id (err 0)
  stmmac_platform: Unknown symbol stmmac_resume (err 0)
  stmmac_platform: Unknown symbol stmmac_dvr_probe (err 0)

Fixes: 50649ab14982 ("stmmac: drop driver from stmmac platform code")
Reported-by: Igor Gnatenko <i.gnatenko.brain@gmail.com>
Signed-off-by: Joachim Eastwood <manabian@gmail.com>
---
Hi,

Sorry for the resend, I managed to screwed up Igor's email address
in the previous one.


An alternative solution could be to change CONFIG_STMMAC_PLATFORM
into a bool, but I guess we want to keep things as modular as
possible.

Please test this Igor and report back. Thanks!

CAFMg4WCm6rs6xMKPiKGmALc45+ne-xUzQgYHH7zOPotQ-iEqjg@mail.gmail.com

 drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
index f3918c7e7eeb..bcdc8955c719 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
@@ -413,3 +413,7 @@ static int stmmac_pltfr_resume(struct device *dev)
 SIMPLE_DEV_PM_OPS(stmmac_pltfr_pm_ops, stmmac_pltfr_suspend,
 				       stmmac_pltfr_resume);
 EXPORT_SYMBOL_GPL(stmmac_pltfr_pm_ops);
+
+MODULE_DESCRIPTION("STMMAC 10/100/1000 Ethernet platform support");
+MODULE_AUTHOR("Giuseppe Cavallaro <peppe.cavallaro@st.com>");
+MODULE_LICENSE("GPL");
-- 
1.8.0

Re: [PATCH RESEND net] stmmac: fix missing MODULE_LICENSE in stmmac_platform

[David Miller]

From: Joachim Eastwood <manabian@gmail.com>
Date: Fri, 31 Jul 2015 19:13:22 +0200

> Sorry for the resend, I managed to screwed up Igor's email address
> in the previous one.

Ok I made sure to use this version.

Re: [PATCH RESEND net] stmmac: fix missing MODULE_LICENSE in stmmac_platform

[Igor Gnatenko]

I've just get's home. It works, thanks for quick fix!

On Fri, Jul 31, 2015 at 8:13 PM, Joachim Eastwood <manabian@gmail.com> wrote:
> Commit 50649ab14982 ("stmmac: drop driver from stmmac platform code")
> was a bit overzealous in removing code and dropped the MODULE_*
> macro's that are still needed since stmmac_platform can be a module.
> Fix this by putting the macro's remvoed in 50649ab14982 back.
>
> This fixes the following errors when used as a module:
>   stmmac_platform: module license 'unspecified' taints kernel.
>   Disabling lock debugging due to kernel taint
>   stmmac_platform: Unknown symbol devm_kmalloc (err 0)
>   stmmac_platform: Unknown symbol stmmac_suspend (err 0)
>   stmmac_platform: Unknown symbol platform_get_irq_byname (err 0)
>   stmmac_platform: Unknown symbol stmmac_dvr_remove (err 0)
>   stmmac_platform: Unknown symbol platform_get_resource (err 0)
>   stmmac_platform: Unknown symbol of_get_phy_mode (err 0)
>   stmmac_platform: Unknown symbol of_property_read_u32_array (err 0)
>   stmmac_platform: Unknown symbol of_alias_get_id (err 0)
>   stmmac_platform: Unknown symbol stmmac_resume (err 0)
>   stmmac_platform: Unknown symbol stmmac_dvr_probe (err 0)
>
> Fixes: 50649ab14982 ("stmmac: drop driver from stmmac platform code")
> Reported-by: Igor Gnatenko <i.gnatenko.brain@gmail.com>
Reported-and-tested-by: Igor Gnatenko <i.gnatenko.brain@gmail.com>
I think also lacks of reference tag.
Reference: https://bugzilla.kernel.org/show_bug.cgi?id=102141
> Signed-off-by: Joachim Eastwood <manabian@gmail.com>
> ---
> Hi,
>
> Sorry for the resend, I managed to screwed up Igor's email address
> in the previous one.
>
>
> An alternative solution could be to change CONFIG_STMMAC_PLATFORM
> into a bool, but I guess we want to keep things as modular as
> possible.
>
> Please test this Igor and report back. Thanks!
>
> CAFMg4WCm6rs6xMKPiKGmALc45+ne-xUzQgYHH7zOPotQ-iEqjg@mail.gmail.com
>
>  drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> index f3918c7e7eeb..bcdc8955c719 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> @@ -413,3 +413,7 @@ static int stmmac_pltfr_resume(struct device *dev)
>  SIMPLE_DEV_PM_OPS(stmmac_pltfr_pm_ops, stmmac_pltfr_suspend,
>                                        stmmac_pltfr_resume);
>  EXPORT_SYMBOL_GPL(stmmac_pltfr_pm_ops);
> +
> +MODULE_DESCRIPTION("STMMAC 10/100/1000 Ethernet platform support");
> +MODULE_AUTHOR("Giuseppe Cavallaro <peppe.cavallaro@st.com>");
> +MODULE_LICENSE("GPL");
> --
> 1.8.0
>



-- 
-Igor Gnatenko