From mboxrd@z Thu Jan 1 00:00:00 1970 From: Harini Katakam Subject: Re: [RFC PATCH 2/2] net: macb: Add 64 bit addressing support for GEM Date: Fri, 18 Nov 2016 16:02:03 +0530 Message-ID: References: <27516aeb-b8f9-dc38-4d01-d2a5c5cf44dd@microchip.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: Rafal Ozieblo , Nicolas Ferre , "harini.katakam@xilinx.com" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" To: Andrei Pistirica Return-path: In-Reply-To: <27516aeb-b8f9-dc38-4d01-d2a5c5cf44dd@microchip.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org tHi Andrei, >> Yes, Andre's version of Cadence does not ability to report have RX >> timestamp. >> The version I worked with did. This is the old series I sent: >> https://lkml.org/lkml/2015/9/11/92 >> But right now, i'm working on building on top of Andre's changes. > > > I'm addressing maintainer's feedback on both patches: > https://patchwork.kernel.org/patch/9310989/ > https://patchwork.kernel.org/patch/9310991/ > > I've done all suggested updates, except the numerous 64bit divisions in the > frequency adjustment callback. I've implemented a different algorithm which > uses 2 64bit division, but I couldn't find a way to use only 1. > > Also, I have a version with timecounter/cyclecounter which shows a much > better accuracy (less than 100ns level). In my opinion this could be a > better implementation. What is you opinion about this? Did you try it? > I did not try timecounter on Cadence IP versions later than r1p06. Because with sub ns precision in HW timestamp, that works better than SW cyclecounter. On older Zynq version, yes timecounter is used and is better. Regards, Harini