From: Harini Katakam <harinikatakamlinux@gmail.com>
To: Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: Harini Katakam <harini.katakam@xilinx.com>,
davem@davemloft.net, netdev@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Punnaiah Choudary Kalluri <punnaia@xilinx.com>,
"michals@xilinx.com" <michals@xilinx.com>,
Neil Armstrong <narmstrong@baylibre.com>
Subject: Re: [RFC PATCH 1/2] net: macb: Correct CAPS mask
Date: Fri, 5 Aug 2016 09:48:14 +0530 [thread overview]
Message-ID: <CAFcVEC+s3d9Lpz54PBygDXC-1s75WJcPxGxb8202gEuaerJDGw@mail.gmail.com> (raw)
In-Reply-To: <f4a7d36f-2686-f8ae-35aa-ca5902cc9197@atmel.com>
On Thu, Aug 4, 2016 at 7:37 PM, Nicolas Ferre <nicolas.ferre@atmel.com> wrote:
> Le 01/08/2016 à 09:20, Harini Katakam a écrit :
>> USRIO and JUMBO CAPS have the same mask.
>> Fix the same.
>>
>> Signed-off-by: Harini Katakam <harinik@xilinx.com>
>
> Hi,
> Indeed there's a bug...
>
>
>> ---
>> drivers/net/ethernet/cadence/macb.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/cadence/macb.h b/drivers/net/ethernet/cadence/macb.h
>> index 36893d8..b6fcf10 100644
>> --- a/drivers/net/ethernet/cadence/macb.h
>> +++ b/drivers/net/ethernet/cadence/macb.h
>> @@ -403,11 +403,11 @@
>> #define MACB_CAPS_USRIO_DEFAULT_IS_MII_GMII 0x00000004
>> #define MACB_CAPS_NO_GIGABIT_HALF 0x00000008
>> #define MACB_CAPS_USRIO_DISABLED 0x00000010
>> +#define MACB_CAPS_JUMBO 0x00000020
>> #define MACB_CAPS_FIFO_MODE 0x10000000
>> #define MACB_CAPS_GIGABIT_MODE_AVAILABLE 0x20000000
>> #define MACB_CAPS_SG_DISABLED 0x40000000
>> #define MACB_CAPS_MACB_IS_GEM 0x80000000
>> -#define MACB_CAPS_JUMBO 0x00000010
>
> Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
>
> Can you please send it independently without the RFC tag in the subject
> and with the following tags in the body as well:
>
> Fixes: ce721a702197 ("net: ethernet: cadence-macb: Add disabled usrio caps")
> Cc: stable@vger.kernel.org # v4.5+
>
Thanks Nicolas. I'll do that.
Regards,
Harini
>> /* Bit manipulation macros */
>> #define MACB_BIT(name) \
>>
>
> Thanks, bye,
> --
> Nicolas Ferre
prev parent reply other threads:[~2016-08-05 4:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-01 7:20 [RFC PATCH 1/2] net: macb: Correct CAPS mask Harini Katakam
2016-08-01 7:20 ` [RFC PATCH 2/2] net: macb: Add 64 bit addressing support for GEM Harini Katakam
2016-08-04 14:07 ` [RFC PATCH 1/2] net: macb: Correct CAPS mask Nicolas Ferre
2016-08-05 4:18 ` Harini Katakam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFcVEC+s3d9Lpz54PBygDXC-1s75WJcPxGxb8202gEuaerJDGw@mail.gmail.com \
--to=harinikatakamlinux@gmail.com \
--cc=davem@davemloft.net \
--cc=harini.katakam@xilinx.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michals@xilinx.com \
--cc=narmstrong@baylibre.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=punnaia@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).