From: "Igor Maravić" <igorm@etf.rs>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCH net-next] r8169: Support for byte queue limits
Date: Sat, 17 Dec 2011 18:28:30 +0100 [thread overview]
Message-ID: <CAFdo_mUcUXhZK20t92NJCetcPV=tst9EYTUhHdbhFU0=FjY2dA@mail.gmail.com> (raw)
In-Reply-To: <1324071003.2621.33.camel@edumazet-laptop>
> Why here in rtl8169_xmit_frags() ?
>
> If done from rtl8169_start_xmit(), you already have "dev" pointer.
>
> netdev_sent_queue(dev, skb->len);
>
I put it there because actual dma maping is occurring in that function.
Logically there is no difference if I put it after calling of function
rtl8169_xmit_frags() in rtl8169_start_xmit().
If You think it would be better to be in function rtl8169_start_xmit,
for performance reasons I'l put it there.
In any case I'l resubmit this patch in Monday. After all it's Saturday :)
BR
Igor
next prev parent reply other threads:[~2011-12-17 17:28 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-12 13:00 [PATCH net-next] r8169: Support for byte queue limits igorm
2011-12-16 21:15 ` David Miller
2011-12-16 21:30 ` Eric Dumazet
2011-12-17 17:28 ` Igor Maravić [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-12-19 10:28 igorm
2011-12-19 19:18 ` David Miller
2011-12-19 10:09 igorm
2011-12-19 10:19 ` Eric Dumazet
2011-12-19 9:27 igorm
2011-12-19 9:29 ` Igor Maravić
2011-12-19 9:46 ` Eric Dumazet
2011-12-19 9:53 ` Igor Maravić
2011-12-06 9:13 igorm
2011-12-06 9:15 ` Igor Maravić
2011-12-06 18:13 ` David Miller
2011-12-06 21:36 ` Igor Maravić
2011-12-06 21:41 ` David Miller
2011-12-02 13:09 igorm
2011-12-02 14:29 ` Eric Dumazet
2011-12-02 14:54 ` Igor Maravić
2011-12-02 15:11 ` Eric Dumazet
2011-12-02 16:31 ` "Igor Maravić"
2011-12-02 16:47 ` Eric Dumazet
2011-12-02 17:00 ` Igor Maravić
2011-12-02 17:12 ` Eric Dumazet
2011-12-02 21:54 ` Igor Maravić
2011-12-03 6:48 ` Eric Dumazet
2011-12-03 0:20 ` Francois Romieu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFdo_mUcUXhZK20t92NJCetcPV=tst9EYTUhHdbhFU0=FjY2dA@mail.gmail.com' \
--to=igorm@etf.rs \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).