From: Ley Foon Tan <lftan@altera.com>
To: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
Cc: Vince Bridgers <vbridgers2013@gmail.com>,
Chen-Yu Tsai <wens@csie.org>, netdev <netdev@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Vince Bridgers <vbridger@altera.com>
Subject: Re: [PATCH] net: stmmac: add dcrs parameter
Date: Wed, 27 Aug 2014 09:27:19 +0800 [thread overview]
Message-ID: <CAFiDJ59fhY7yDHT_VLhhSS7-=bCRXPUx_tFS66NP5pHCVH+uJw@mail.gmail.com> (raw)
In-Reply-To: <53FC89A0.8040905@st.com>
On Tue, Aug 26, 2014 at 9:20 PM, Giuseppe CAVALLARO
<peppe.cavallaro@st.com> wrote:
>>>
>>>
>>>
>>> Indeed this is what I had done in the patch.
>>>
>>>
>>> http://git.stlinux.com/?p=stm/linux-sh4-2.6.32.y.git;a=commit;h=b0b863bf65c36dc593f6b7b4b418394fd880dae2
>>>
>>> Also in case of carrier sense the frame will be dropped in any case
>>> later.
>>>
>>> Let me know if you Acked this patch so I will rebase it on
>>> net.git and I send it soon
>>>
>>> peppe
>>>
>>
>> Yes, this looks good to me. I don't expect anyone is using 10Base2 or
>> 10Base5 anymore, so it's ok to disable DCRS by default.
>>
>> ack
>>
>> All the best,
>
>
> thx so much, I will send this patch (with your Acked-by) and ported on
> net.git soon.
>
> Chen-Yu, Ley Foon, pls let me know if it is ok for you as well
I'm fine with your patch.
Thanks.
Regards
Ley Foon
next prev parent reply other threads:[~2014-08-27 1:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-25 11:50 [PATCH] net: stmmac: add dcrs parameter Ley Foon Tan
2014-08-25 12:23 ` Giuseppe CAVALLARO
2014-08-25 12:34 ` Chen-Yu Tsai
2014-08-25 12:51 ` Giuseppe CAVALLARO
2014-08-25 15:10 ` Vince Bridgers
2014-08-26 5:38 ` Giuseppe CAVALLARO
2014-08-26 12:35 ` Vince Bridgers
2014-08-26 13:20 ` Giuseppe CAVALLARO
2014-08-27 1:27 ` Ley Foon Tan [this message]
2014-08-27 2:36 ` Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFiDJ59fhY7yDHT_VLhhSS7-=bCRXPUx_tFS66NP5pHCVH+uJw@mail.gmail.com' \
--to=lftan@altera.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=vbridger@altera.com \
--cc=vbridgers2013@gmail.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).