From: Jon Maxwell <jmaxwell@redhat.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Jon Maxwell <jmaxwell37@gmail.com>,
"Miller, David" <davem@davemloft.net>,
edumazet@google.com, ncardwell@google.com,
David.Laight@aculab.com, kuznet@ms2.inr.ac.ru,
yoshfuji@linux-ipv6.org, netdev@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next 0/3] Series to improve setsockopt() TCP_USER_TIMEOUT accuracy
Date: Tue, 17 Jul 2018 15:40:28 +1000 [thread overview]
Message-ID: <CAFjuzB9632y6RbdxvjUBWXQX8YbSO7GJ6TWP_SCtrpt4Vy5t1w@mail.gmail.com> (raw)
In-Reply-To: <0cdd742b-ad2e-aeac-c85f-21c59333d54d@gmail.com>
On Tue, Jul 17, 2018 at 2:56 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
>
>
> On 07/16/2018 09:15 PM, Jon Maxwell wrote:
>> This is a patch series based on:
>>
>> Jon Maxwell (3):
>> [PATCH net-next 1/3] tcp: convert icsk_user_timeout from jiffies to msecs
>> [PATCH net-next v1 2/3] tcp: convert icsk_user_timeout from jiffies to msecs
>> [PATCH net-next v1 3/3] tcp: convert icsk_user_timeout from jiffies to msecs
>
> This would have been nice to use meaningful titles for each patch,
> instead of copy/pasting the first one ?
>
> Thanks !
>
>
>
This is my 1st time doing a patch series. Let me rebase and resubmit
each with a more descriptive title.
But 1st do I still need to put the patch number in the series? Even if
the title differs?
1) e.g:
Jon Maxwell (3):
[PATCH net-next 1/3] tcp: convert icsk_user_timeout from jiffies to msecs
[PATCH net-next 2/3] tcp: Add tcp_retransmit_stamp() helper
[PATCH net-next 3/3] tcp: Add tcp_clamp_rto_to_user_timeout() to
improve accuracy
2) or:
Jon Maxwell (3):
[PATCH net-next] tcp: convert icsk_user_timeout from jiffies to msecs
[PATCH net-next] tcp: Add tcp_retransmit_time() helper
[PATCH net-next] tcp: Add tcp_clamp_rto_to_user_timeout() to
improve TCP_USER_TIMEOUT accuracy
Which is preferred (1) or (2)? Are the above titles descriptive enough?
Regards
Jon
prev parent reply other threads:[~2018-07-17 5:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-17 4:15 [PATCH net-next 0/3] Series to improve setsockopt() TCP_USER_TIMEOUT accuracy Jon Maxwell
2018-07-17 4:56 ` Eric Dumazet
2018-07-17 5:40 ` Jon Maxwell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFjuzB9632y6RbdxvjUBWXQX8YbSO7GJ6TWP_SCtrpt4Vy5t1w@mail.gmail.com \
--to=jmaxwell@redhat.com \
--cc=David.Laight@aculab.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=jmaxwell37@gmail.com \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).