From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f66.google.com ([209.85.215.66]:43928 "EHLO mail-lf0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753878AbeCFUx0 (ORCPT ); Tue, 6 Mar 2018 15:53:26 -0500 Received: by mail-lf0-f66.google.com with SMTP id q69so30538306lfi.10 for ; Tue, 06 Mar 2018 12:53:25 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20180216162849.GA10860@jordon-HP-15-Notebook-PC> References: <20180216162849.GA10860@jordon-HP-15-Notebook-PC> From: Souptick Joarder Date: Wed, 7 Mar 2018 02:23:24 +0530 Message-ID: Subject: Re: [PATCH] net: Use dma_pool_zalloc() To: =?UTF-8?Q?Krzysztof_Ha=C5=82asa?= , netdev@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org List-ID: Any comment for this patch. On Fri, Feb 16, 2018 at 9:58 PM, Souptick Joarder wrote: > Use dma_pool_zalloc() instead of dma_pool_alloc + memset > > Signed-off-by: Souptick Joarder > --- > drivers/net/ethernet/xscale/ixp4xx_eth.c | 3 +-- > drivers/net/wan/ixp4xx_hss.c | 3 +-- > 2 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/ethernet/xscale/ixp4xx_eth.c b/drivers/net/ethernet/xscale/ixp4xx_eth.c > index aee55c0..5710ae8 100644 > --- a/drivers/net/ethernet/xscale/ixp4xx_eth.c > +++ b/drivers/net/ethernet/xscale/ixp4xx_eth.c > @@ -1108,10 +1108,9 @@ static int init_queues(struct port *port) > return -ENOMEM; > } > > - if (!(port->desc_tab = dma_pool_alloc(dma_pool, GFP_KERNEL, > + if (!(port->desc_tab = dma_pool_zalloc(dma_pool, GFP_KERNEL, > &port->desc_tab_phys))) > return -ENOMEM; > - memset(port->desc_tab, 0, POOL_ALLOC_SIZE); > memset(port->rx_buff_tab, 0, sizeof(port->rx_buff_tab)); /* tables */ > memset(port->tx_buff_tab, 0, sizeof(port->tx_buff_tab)); > > diff --git a/drivers/net/wan/ixp4xx_hss.c b/drivers/net/wan/ixp4xx_hss.c > index 6a505c2..0caffbf 100644 > --- a/drivers/net/wan/ixp4xx_hss.c > +++ b/drivers/net/wan/ixp4xx_hss.c > @@ -976,10 +976,9 @@ static int init_hdlc_queues(struct port *port) > return -ENOMEM; > } > > - if (!(port->desc_tab = dma_pool_alloc(dma_pool, GFP_KERNEL, > + if (!(port->desc_tab = dma_pool_zalloc(dma_pool, GFP_KERNEL, > &port->desc_tab_phys))) > return -ENOMEM; > - memset(port->desc_tab, 0, POOL_ALLOC_SIZE); > memset(port->rx_buff_tab, 0, sizeof(port->rx_buff_tab)); /* tables */ > memset(port->tx_buff_tab, 0, sizeof(port->tx_buff_tab)); > > -- > 1.9.1 >