From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 877A98564E for ; Thu, 9 May 2024 21:19:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715289592; cv=none; b=AWgXXM1+6fefVlazGQI1BO0rGZ0zyxLN9QJkQ/8lN/wwLsQdaO6SAP8BrMFKUUBL2SOe6KfhOlfXLuzxIPSoJ4tDCUDr2wVRsUz1btaGr/coQozKk1dhoGlvWdaxSHVE1OrHQUvW9ZeHKmOJHJAHMhNEctRT5AP7UBFeNAdjxso= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715289592; c=relaxed/simple; bh=XSTDg6D+nuKKMmgCY9p7yR4M1jZiN3nKiFZMyRMCGiE=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=AqcKGWvaJcqN42Baoo8rT5SRMYOdk4wh6LTDwvrAwnP4ZjAMAXsYe81wadowFwW2H/4l4+mQX+1Erab/1WiDYHbUAHzflYtsUQI2Z8+Si0SwNKO1wvmThZFOxi8oVX0G4Mag6bjM8J2R/0Pa1QHH9xwSw18x90KUuXoKLpKmTOs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=K2+KNowD; arc=none smtp.client-ip=209.85.208.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="K2+KNowD" Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-572a1b3d6baso1769a12.1 for ; Thu, 09 May 2024 14:19:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1715289589; x=1715894389; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Qgi3h+IjdR+qGYdA2wxHQV5wR5eEl2tpr3YsgoeQfBs=; b=K2+KNowDh/Yz/vPO9MXcNjzhsuN/gWefqx5FxmGiRNGlSzlZlMoSiGxPN60Xq/Ed2l 1/3Ozuph4mG4ufldGWP6gWVOi0kCMsTieIgwL11BFBxIByeSNiMkkgyEd0JgTKrgjOde 9eI5HKP3UYI4ye0ijUXnlyaGpUqzXzTC3uKPmib0Hv001oil5RlXORP2uYm/kcHiC4pE HBqbIUSV18QJoagx3z+a4V3ofsIT0u4ahbQlCQYmrNYRr/pl/pElNRhaIYZ8nKaowLVg A+7oZaw7IayZHTcznNMMW3jT628E52s7PqSCsf1cxnjOserKAWs720mlvlOlFpAkrsCm SR7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715289589; x=1715894389; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Qgi3h+IjdR+qGYdA2wxHQV5wR5eEl2tpr3YsgoeQfBs=; b=tNnFpmOhkrCjzhPYGh07n0cWXs4u6Cd7qzMQZCIZ1lZIYWIb7QUVrIQ0HvuGHcsOEV Yo656SEBTllTW9CmGHEEqgmWFrhQD72NBlnNgtqe/nTqkzRFXi+4DEZ3AOFDWrrrA1Mq yeeTAMeuXj8XngNeUJxYaIijJMomDbp6L5tlmLj7Lb+eXU0NrLBtmwLbyeylC9kNknb8 Y0vj6yNNVSUKSC391O/HfH9XRyNVwPBpV16Xsvp12rYKZp1N8dRjLtC+COgIRr7B07qN 5wnqsmsdUwrWWvfiyrn55lQUiYLGrNw6bPXLM0H4TM9xOXEGUEnhWfzSKQUBUrspzvh9 emag== X-Forwarded-Encrypted: i=1; AJvYcCXNQqefsLgbzjis8Jsdsvz0OaqOYz376jfau6w+S3f51Zm20ctKKBXwNezUC6Hq2jUf9fzAAFcfFOkIa9/SF6m1urBA2Q+O X-Gm-Message-State: AOJu0Yy92D6eGpSPhuF7MFBV+QG3njOClg/+CH3uUplt+xy3yxx5AzKe tGbS3OhwnKVPeCIQ9yTXjl9/88osC7q8CCOYbtBHH8N0BMHj5FQq0G5aOyH5FMePn2/+hdSgCCY vhzG4FAWHNzf0gQDGryQQfmqpeRKvr0nCjWA0 X-Google-Smtp-Source: AGHT+IESFwBeKEPJHXIvjKnYagQw1HEdTMzk6jry3RDX75zlENIpGV8y1GohMsEmGFBkNbvjuiuL//wMmjE86393x/o= X-Received: by 2002:a50:85cb:0:b0:573:438c:7789 with SMTP id 4fb4d7f45d1cf-57351de5880mr11488a12.1.1715289588869; Thu, 09 May 2024 14:19:48 -0700 (PDT) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240509200022.253089-14-edliaw@google.com> <20240509203113.63537-1-sj@kernel.org> In-Reply-To: <20240509203113.63537-1-sj@kernel.org> From: Edward Liaw Date: Thu, 9 May 2024 14:19:23 -0700 Message-ID: Subject: Re: [PATCH v3 13/68] selftests/damon: Drop define _GNU_SOURCE To: SeongJae Park Cc: shuah@kernel.org, =?UTF-8?B?TWlja2HDq2wgU2FsYcO8bg==?= , =?UTF-8?Q?G=C3=BCnther_Noack?= , Christian Brauner , Richard Cochran , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexei Starovoitov , Daniel Borkmann , "David S. Miller" , Jakub Kicinski , Jesper Dangaard Brouer , John Fastabend , Muhammad Usama Anjum , Andrew Morton , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@android.com, linux-security-module@vger.kernel.org, netdev@vger.kernel.org, linux-riscv@lists.infradead.org, bpf@vger.kernel.org, damon@lists.linux.dev, linux-mm@kvack.org, mathieu.desnoyers@efficios.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, May 9, 2024 at 1:31=E2=80=AFPM SeongJae Park wrote: > > Hi Edward, > > On Thu, 9 May 2024 19:58:05 +0000 Edward Liaw wrote: > > > _GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent > > redefinition warnings. > > > > Fixes: 809216233555 ("selftests/harness: remove use of LINE_MAX") > > I show Mathieu's comment on this[1]. I have no strong opinion on this, b= ut if > you conclude to remove or change this line, please apply same change to t= his > patch. Will do, thanks for reviewing. > > [1] https://lore.kernel.org/638a7831-493c-4917-9b22-5aa663e9ee84@efficios= .com > > > Signed-off-by: Edward Liaw > > I also added trivial comments that coming from my personal and humble > preferrence below. Other than the above and the below comments, > > Reviewed-by: SeongJae Park > > > --- > > tools/testing/selftests/damon/debugfs_target_ids_pid_leak.c | 3 --- > > .../damon/debugfs_target_ids_read_before_terminate_race.c | 2 -- > > 2 files changed, 5 deletions(-) > > > > diff --git a/tools/testing/selftests/damon/debugfs_target_ids_pid_leak.= c b/tools/testing/selftests/damon/debugfs_target_ids_pid_leak.c > > index 0cc2eef7d142..7a17a03d555c 100644 > > --- a/tools/testing/selftests/damon/debugfs_target_ids_pid_leak.c > > +++ b/tools/testing/selftests/damon/debugfs_target_ids_pid_leak.c > > @@ -2,9 +2,6 @@ > > /* > > * Author: SeongJae Park > > */ > > - > > -#define _GNU_SOURCE > > - > > #include > > I'd prefer having one empty line between the comment and includes. > > > #include > > #include > > diff --git a/tools/testing/selftests/damon/debugfs_target_ids_read_befo= re_terminate_race.c b/tools/testing/selftests/damon/debugfs_target_ids_read= _before_terminate_race.c > > index b06f52a8ce2d..4aeac55ac93e 100644 > > --- a/tools/testing/selftests/damon/debugfs_target_ids_read_before_term= inate_race.c > > +++ b/tools/testing/selftests/damon/debugfs_target_ids_read_before_term= inate_race.c > > @@ -2,8 +2,6 @@ > > /* > > * Author: SeongJae Park > > */ > > -#define _GNU_SOURCE > > - > > #include > > Ditto. > > And I realize I also forgot adding one empty line before the above #defin= e > line. That's why I'm saying this is just a trivial comment :) No problem, I will add it back in. Thanks, Edward > > > #include > > #include > > -- > > 2.45.0.118.g7fe29c98d7-goog > > > Thanks, > SJ