From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vijay Subramanian Subject: Re: [PATCH 2/7] atm: replace del_timer by del_timer_sync Date: Wed, 26 Mar 2014 15:19:16 -0700 Message-ID: References: <1395869625-15209-1-git-send-email-Julia.Lawall@lip6.fr> <1395869625-15209-3-git-send-email-Julia.Lawall@lip6.fr> <1395871015.12610.254.camel@edumazet-glaptop2.roam.corp.google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Cc: Julia Lawall , "David S. Miller" , kernel-janitors@vger.kernel.org, tglx@linutronix.de, netdev , linux-kernel@vger.kernel.org To: Eric Dumazet Return-path: In-Reply-To: <1395871015.12610.254.camel@edumazet-glaptop2.roam.corp.google.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org > > It seems this timer rearms itself, so this patch wont be enough I fear. > > > Does that matter? It seems del_timer_sync() may be intended to work despite this (i.e. timer will not fire after call to this function). My earlier attempt to fix a similar issue in sch_red.c resulted in this explanation. http://www.spinics.net/lists/netdev/msg256410.html Vijay