From: Julian Calaby <julian.calaby@gmail.com>
To: Javier Martinez Canillas <javier@osg.samsung.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Amitkumar Karwar <akarwar@marvell.com>,
Kalle Valo <kvalo@codeaurora.org>,
netdev <netdev@vger.kernel.org>,
linux-wireless <linux-wireless@vger.kernel.org>,
Nishant Sarmukadam <nishants@marvell.com>
Subject: Re: [PATCH] mwifiex: fix unconditional error return in .add_virtual_intf callback
Date: Mon, 4 Jul 2016 10:18:52 +1000 [thread overview]
Message-ID: <CAGRGNgUdUf2TC1ix-uZNR+kuNApLXduAivMY=3AmgXKDx-cxyg@mail.gmail.com> (raw)
In-Reply-To: <1467401982-18943-1-git-send-email-javier@osg.samsung.com>
Hi All,
On Sat, Jul 2, 2016 at 5:39 AM, Javier Martinez Canillas
<javier@osg.samsung.com> wrote:
> The commit 7311ea850079 ("mwifiex: fix AP start problem for newly added
> interface") attempted to fix an issue when a new AP interface is added.
>
> But the patch didn't check the return value of the functions doing the
> firmware calls and returned an error even if the functions didn't fail.
>
> This prevents the network device to be registered properly, so fix it.
>
> Fixes: commit 7311ea850079 ("mwifiex: fix AP start problem for newly added interface")
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Looks correct to me as Dan Carpenter submitted the same fix.
Reviewed-by: Julian Calaby <julian.calaby@gmail.com>
Thanks,
--
Julian Calaby
Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
next prev parent reply other threads:[~2016-07-04 0:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-01 19:39 [PATCH] mwifiex: fix unconditional error return in .add_virtual_intf callback Javier Martinez Canillas
2016-07-04 0:18 ` Julian Calaby [this message]
2016-07-05 13:09 ` Kalle Valo
2016-07-05 13:14 ` Javier Martinez Canillas
2016-07-05 13:28 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGRGNgUdUf2TC1ix-uZNR+kuNApLXduAivMY=3AmgXKDx-cxyg@mail.gmail.com' \
--to=julian.calaby@gmail.com \
--cc=akarwar@marvell.com \
--cc=javier@osg.samsung.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nishants@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).