From: Julian Calaby <julian.calaby@gmail.com>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: netdev <netdev@vger.kernel.org>,
Dmitry Vyukov <dvyukov@google.com>,
Eric Dumazet <eric.dumazet@gmail.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
Lauro Ramos Venancio <lauro.venancio@openbossa.org>,
Aloisio Almeida Jr <aloisio.almeida@openbossa.org>,
Samuel Ortiz <sameo@linux.intel.com>
Subject: Re: [PATCH v2 net] nfc: use GFP_USER for user-controlled kmalloc
Date: Sat, 30 Jan 2016 09:01:56 +1100 [thread overview]
Message-ID: <CAGRGNgW16nQrvuePehmiirLxJpO-Oatd6iMP_tXQfu8JjmoVnA@mail.gmail.com> (raw)
In-Reply-To: <1454096764.7627.66.camel@edumazet-glaptop2.roam.corp.google.com>
Hi Cong
On Sat, Jan 30, 2016 at 6:46 AM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
> On Fri, 2016-01-29 at 11:24 -0800, Cong Wang wrote:
>> These two functions are called in sendmsg path, and the
>> 'len' is passed from user-space, so we should not allow
>> malicious users to OOM kernel on purpose.
>>
>> Reported-by: Dmitry Vyukov <dvyukov@google.com>
>> Cc: Lauro Ramos Venancio <lauro.venancio@openbossa.org>
>> Cc: Aloisio Almeida Jr <aloisio.almeida@openbossa.org>
>> Cc: Samuel Ortiz <sameo@linux.intel.com>
>> Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
>> ---
>
> Note that the issue is not OOM the kernel (as the allocation is
> attempted even after your patch), but having a way to
> spill stack traces in the syslog.
>
> Acked-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Julian Calaby <julian.calaby@gmail.com>
Thanks,
--
Julian Calaby
Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
next prev parent reply other threads:[~2016-01-29 22:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-29 19:24 [PATCH v2 net] nfc: use GFP_USER for user-controlled kmalloc Cong Wang
2016-01-29 19:46 ` Eric Dumazet
2016-01-29 22:01 ` Julian Calaby [this message]
[not found] ` <1454095465-16685-1-git-send-email-xiyou.wangcong-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-02-24 18:41 ` Cong Wang
2016-02-24 18:45 ` David Miller
[not found] ` <20160224.134521.961009575129127582.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2016-02-24 18:53 ` Cong Wang
[not found] ` <CAM_iQpX3X6YoFeMw2KYjJM8yBHi9=3iapo0+a9Cqtc0cxM_QNA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-02-24 18:52 ` Samuel Ortiz
2016-02-25 7:43 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGRGNgW16nQrvuePehmiirLxJpO-Oatd6iMP_tXQfu8JjmoVnA@mail.gmail.com \
--to=julian.calaby@gmail.com \
--cc=aloisio.almeida@openbossa.org \
--cc=dvyukov@google.com \
--cc=eric.dumazet@gmail.com \
--cc=lauro.venancio@openbossa.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).