From: Florian Fainelli <f.fainelli@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: netdev <netdev@vger.kernel.org>,
Vince Bridgers <vbridgers2013@gmail.com>
Subject: Re: [PATCH net-next] net: phy: export phy_suspend and phy_resume
Date: Tue, 8 Jul 2014 20:59:47 -0700 [thread overview]
Message-ID: <CAGVrzcYkswjw+kd3A3BJxXeyeUHvr4D+Ud7btNnJ=SRwP5AppA@mail.gmail.com> (raw)
In-Reply-To: <20140708.203734.373515318594628840.davem@davemloft.net>
2014-07-08 20:37 GMT-07:00 David Miller <davem@davemloft.net>:
> From: Florian Fainelli <f.fainelli@gmail.com>
> Date: Tue, 8 Jul 2014 10:38:36 -0700
>
>> phy_suspend and phy_resume are two commonly used helper functions that
>> need to be exported for Ethernet drivers to be built as modules
>>
>> Fixes: 40755a0fce17 ("net: systemport: add suspend and resume support")
>> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
>
> First of all, the commit in question went into 'net' not 'net-next'.
I am confused now, because I sent the patches against net-next and
still see them in your net-next tree here:
https://git.kernel.org/cgit/linux/kernel/git/davem/net-next.git/commit/?id=40755a0fce17c39557fd55b634024082671074ed
>
> Second of all, I reverted it.
I remember you replied to Vince about his patches which also depended
on phy_suspend/resume to be there and you did revert his changes.
>
> So this patch is not appropriate unless/until that commit gets
> re-added, and it's not targetted at the proper tree anyways.
--
Florian
next prev parent reply other threads:[~2014-07-09 4:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-08 17:38 [PATCH net-next] net: phy: export phy_suspend and phy_resume Florian Fainelli
2014-07-09 3:37 ` David Miller
2014-07-09 3:59 ` Florian Fainelli [this message]
2014-07-09 4:06 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGVrzcYkswjw+kd3A3BJxXeyeUHvr4D+Ud7btNnJ=SRwP5AppA@mail.gmail.com' \
--to=f.fainelli@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=vbridgers2013@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).