From: Florian Fainelli <f.fainelli@gmail.com>
To: Daniel Mack <zonque@gmail.com>
Cc: netdev <netdev@vger.kernel.org>,
David Miller <davem@davemloft.net>,
mugunthanvnm <mugunthanvnm@ti.com>,
ujhelyi.m@gmail.com
Subject: Re: [PATCH net-next RESEND 1/2] net: phy: export genphy_config_init()
Date: Wed, 16 Apr 2014 12:14:03 -0700 [thread overview]
Message-ID: <CAGVrzcbwRod-YSXKJ1hgd81SaPHkB7mEMWFZbEa1yaBUU-134A@mail.gmail.com> (raw)
In-Reply-To: <1397661553-22117-1-git-send-email-zonque@gmail.com>
2014-04-16 8:19 GMT-07:00 Daniel Mack <zonque@gmail.com>:
> This enables other drivers to call this generic implementation, and then
> only do specific details on top of it.
>
> Signed-off-by: Daniel Mack <zonque@gmail.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> Resending this after 3.15-rc1 has been released, assuming that the
> net-next tree is now open again.
>
> drivers/net/phy/phy_device.c | 3 ++-
> include/linux/phy.h | 1 +
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c
> index 2f6989b..84485ea 100644
> --- a/drivers/net/phy/phy_device.c
> +++ b/drivers/net/phy/phy_device.c
> @@ -1029,7 +1029,7 @@ static int gen10g_read_status(struct phy_device *phydev)
> return 0;
> }
>
> -static int genphy_config_init(struct phy_device *phydev)
> +int genphy_config_init(struct phy_device *phydev)
> {
> int val;
> u32 features;
> @@ -1074,6 +1074,7 @@ static int genphy_config_init(struct phy_device *phydev)
>
> return 0;
> }
> +EXPORT_SYMBOL(genphy_config_init);
>
> static int gen10g_config_init(struct phy_device *phydev)
> {
> diff --git a/include/linux/phy.h b/include/linux/phy.h
> index 565188c..dcf7f13 100644
> --- a/include/linux/phy.h
> +++ b/include/linux/phy.h
> @@ -609,6 +609,7 @@ static inline int phy_read_status(struct phy_device *phydev)
> return phydev->drv->read_status(phydev);
> }
>
> +int genphy_config_init(struct phy_device *phydev);
> int genphy_setup_forced(struct phy_device *phydev);
> int genphy_restart_aneg(struct phy_device *phydev);
> int genphy_config_aneg(struct phy_device *phydev);
> --
> 1.9.0
>
--
Florian
next prev parent reply other threads:[~2014-04-16 19:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-16 15:19 [PATCH net-next RESEND 1/2] net: phy: export genphy_config_init() Daniel Mack
2014-04-16 15:19 ` [PATCH net-next RESEND 2/2] net: phy: at803x: use genphy_config_init() Daniel Mack
2014-04-16 19:14 ` Florian Fainelli
2014-04-20 22:19 ` David Miller
2014-04-16 19:14 ` Florian Fainelli [this message]
2014-04-20 22:19 ` [PATCH net-next RESEND 1/2] net: phy: export genphy_config_init() David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGVrzcbwRod-YSXKJ1hgd81SaPHkB7mEMWFZbEa1yaBUU-134A@mail.gmail.com \
--to=f.fainelli@gmail.com \
--cc=davem@davemloft.net \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
--cc=ujhelyi.m@gmail.com \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).