From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kees Cook Subject: Re: [PATCH 31/31] timer: Switch to testing for .function instead of .data Date: Thu, 31 Aug 2017 16:59:05 -0700 Message-ID: References: <1504222183-61202-1-git-send-email-keescook@chromium.org> <1504222183-61202-32-git-send-email-keescook@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Cc: Thomas Gleixner , "Rafael J. Wysocki" , Pavel Machek , Len Brown , Greg Kroah-Hartman , Mike Marciniszyn , Dennis Dalessandro , Doug Ledford , Sean Hefty , Hal Rosenstock , Jeff Kirsher , "linux-pm@vger.kernel.org" , linux-rdma , "linux-input@vger.kernel.org" , intel-wired-lan@lists.osuosl.org, netdev , lkml To: Dmitry Torokhov Return-path: In-Reply-To: Sender: linux-pm-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Thu, Aug 31, 2017 at 4:45 PM, Dmitry Torokhov wrote: > On Thu, Aug 31, 2017 at 4:29 PM, Kees Cook wrote: >> In several places, .data is checked for initialization to gate early >> calls to del_timer_sync(). Checking for .function is equally valid, so >> switch to this in all callers. > > Not seeing the rest of patches it is unclear from the patch > description why this is needed/wanted. The CC list would have been really giant, but here is the first patch and the earlier series list: https://lkml.org/lkml/2017/8/31/904 https://lkml.org/lkml/2017/8/30/760 tl;dr: We're going to switch all struct timer_list callbacks to get the timer pointer as the argument instead of from the .data field. This patch is one step in removing open-coded users of the .data field. -Kees -- Kees Cook Pixel Security