From: Kees Cook <keescook@chromium.org>
To: David Laight <David.Laight@aculab.com>
Cc: Paul Bolle <pebolle@tiscali.nl>,
Karsten Keil <isdn@linux-pingi.de>,
"David S. Miller" <davem@davemloft.net>,
Johan Hovold <johan@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
"gigaset307x-common@lists.sourceforge.net"
<gigaset307x-common@lists.sourceforge.net>,
Network Development <netdev@vger.kernel.org>
Subject: Re: [PATCH v2] isdn/gigaset: Convert timers to use timer_setup()
Date: Mon, 9 Oct 2017 10:36:14 -0700 [thread overview]
Message-ID: <CAGXu5jKPm_KnLsS9Aj==r5fb7WCncFetKrbzdA4xkiW3ujx62Q@mail.gmail.com> (raw)
In-Reply-To: <063D6719AE5E284EB5DD2968C1650D6DD008D392@AcuExch.aculab.com>
On Mon, Oct 9, 2017 at 2:15 AM, David Laight <David.Laight@aculab.com> wrote:
> From: Kees Cook
>> Sent: 06 October 2017 20:40
> ...
>> I'm in no rush for any specific change. There are about 900 call sites
>> I'm making my way through, about 2/3rd are pretty trivial, and the
>> less obvious is what I've started sending out now, since I expect some
>> will need some more careful review.
>
> Is it worth adding a structure that contains a timer and an extra 'long'
> than can be used to maintain the existing API logic for the 'difficult'
> cases?
I didn't want to have this available in the general case, since I'd
like to get all the conversions actually finished. There are a couple
very special cases that need this, and they have one-off structs that
do this.
-Kees
--
Kees Cook
Pixel Security
prev parent reply other threads:[~2017-10-09 17:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-05 19:31 [PATCH v2] isdn/gigaset: Convert timers to use timer_setup() Kees Cook
2017-10-06 19:00 ` Paul Bolle
2017-10-06 19:39 ` Kees Cook
2017-10-09 9:15 ` David Laight
2017-10-09 17:36 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGXu5jKPm_KnLsS9Aj==r5fb7WCncFetKrbzdA4xkiW3ujx62Q@mail.gmail.com' \
--to=keescook@chromium.org \
--cc=David.Laight@aculab.com \
--cc=davem@davemloft.net \
--cc=gigaset307x-common@lists.sourceforge.net \
--cc=isdn@linux-pingi.de \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pebolle@tiscali.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).