From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E50C41EE7DC for ; Fri, 15 Aug 2025 03:50:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755229860; cv=none; b=p7kk4UNxcRWbusuiWorvyxJuS7eYn/U2yIuJraBeswc+ijfgXT1M+4K6F5+JqUqKRAj3aznjT1A3zKkLBZXv+1YNfeudp/n2vlz2WFhQhuppCvZMJDSQKdivKfzEkn2u6mSlgIbEBfqTH2DIioF0N1xmNOhbjIoHuM6v0HOh62A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755229860; c=relaxed/simple; bh=c2pC85ElO+tZ8p0q9KcefHan237MX0I5q5DFQRsj70M=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=hTu2m6ObPOvPecDaa8ny25kz9D996d9PHkWiPixSItQ9lgPuEu0UrdoLMV4lAfMQRxHTAXdOibZT7BkeUPlKFXUz3kHvnM51OkK1FWQ793eyltvsb8xMLtx1Ffme73Uk6/fPfZ1yLmglQR5XJ5df92/NFAQpW4QdSXdiR1KubHY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=VESgFop9; arc=none smtp.client-ip=209.85.167.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="VESgFop9" Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-55ce5284d63so1452219e87.0 for ; Thu, 14 Aug 2025 20:50:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1755229857; x=1755834657; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=mNCpJgQjq+GS4YzNy98cq9BJV9qzo09+hdPjGhITOTw=; b=VESgFop9JXpWUWdR9s3k1FiQgAjftZp2l0yfa8NmqS5SmyE7zyCIsLYxSO6Rx/0Ka1 ZtH/yp4SfNDz5THsdsdQ3BEMRlfqwbLTScOXan3jcYhhrI6Vx2xaaD07zuxGVNyDmfyC s9g3iCUH1r8iHRuBA+NSd1O1VJZZVd29cK3RY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755229857; x=1755834657; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mNCpJgQjq+GS4YzNy98cq9BJV9qzo09+hdPjGhITOTw=; b=Tyd6nosMtMtzEjdxlwurKj4LXoMfB7Y5lM1wtCP7VHGVKepn0G8B9cDN0JmgXNehYK BwfnkXm+gUbCOmAzTNCgqWaWHUC/rkAHGkcIjLq0r8FS5CkZoJUWd1U0KkG+dh0SkhbQ AnwKD+SnvdrjVitjNDALwFvRPPo+WFw+11nJcDJ3aB+ekGXZ2SCMBIpLV6jmkaa+71Vx ZKbUDeXC5xbxFz+FKDWpcTiH0UBFRw/vkotQMAoV351RG8jNyLot9qGFNt0wRho3tsN7 TQBpEquAveupG+zTrOEr7TTw335vQDQpJ4Ig89kWLRlES83yKLq+vg3itfdfUc26z+zD hWIw== X-Forwarded-Encrypted: i=1; AJvYcCUfKpZIiiS5tn0QMMrmnxhaRl2SdPZ1kFJODjXpfb+etejaQksHuNFlX33b3Gx5GvzAZVSoH5g=@vger.kernel.org X-Gm-Message-State: AOJu0YxmyT9giaqIT0hbdzfGnVXWOpssDOnGa2lkjfbnk9XxnPpY9Zuw 9I7ebHkugJeUEG0xJHxwMPYwHq10CVWfU9vvxDrOtNr8rny5+VxFojKRdJYdQ23lxMlZW7JlFlZ WfQE0HAgGXvtdDY6y0Q7qu6PMJP86ChDIuaGdcLzn X-Gm-Gg: ASbGncvCSB7ypJDxIIunJOLvHpKskbZPo+oFyIqQAsCebfm86C/LV4QA8B6IlcY/2KW RZ47ES0MLCdzA1eb0VUmVFHu0jLgwZCokEzD8H4brekX3Tb6zCj+0WHLvfXBF9EVyb1ynmPu0AD uFl5Jb98b25entRh64JnCn49japVCObDFZGjd2Xs8Atju3AIl+H4akySPds9jCe0wgEb26RteBI 1cHeXnLNn9eT50a1R8vEbJsuAVh/oD4mhiHgg== X-Google-Smtp-Source: AGHT+IHanR5W4aT2CMpF63TjQl6R4IN1HWWDRZ1tieU0aIdSV3su7803eNqcJODnfoQ+Iaia8tnU4ymR0P29h1PYZxw= X-Received: by 2002:a05:6512:110c:b0:55b:814a:a7fa with SMTP id 2adb3069b0e04-55ce6276b14mr1674516e87.8.1755229857008; Thu, 14 Aug 2025 20:50:57 -0700 (PDT) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20250805135447.149231-1-laura.nao@collabora.com> <20250805135447.149231-16-laura.nao@collabora.com> In-Reply-To: <20250805135447.149231-16-laura.nao@collabora.com> From: Chen-Yu Tsai Date: Fri, 15 Aug 2025 12:50:46 +0900 X-Gm-Features: Ac12FXwHRx7C4fyOWZyt0EB-zyYHFrLdTdYy_27o2coqKVBHEp62jlgbsZo1EGQ Message-ID: Subject: Re: [PATCH v4 15/27] clk: mediatek: Add MT8196 ufssys clock support To: Laura Nao Cc: mturquette@baylibre.com, sboyd@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, p.zabel@pengutronix.de, richardcochran@gmail.com, guangjie.song@mediatek.com, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, netdev@vger.kernel.org, kernel@collabora.com, =?UTF-8?B?TsOtY29sYXMgRiAuIFIgLiBBIC4gUHJhZG8=?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Aug 5, 2025 at 10:55=E2=80=AFPM Laura Nao = wrote: > > Add support for the MT8196 ufssys clock controller, which provides clock > gate control for UFS. > > Reviewed-by: N=C3=ADcolas F. R. A. Prado > Co-developed-by: AngeloGioacchino Del Regno > Signed-off-by: AngeloGioacchino Del Regno > Signed-off-by: Laura Nao > --- > drivers/clk/mediatek/Kconfig | 7 ++ > drivers/clk/mediatek/Makefile | 1 + > drivers/clk/mediatek/clk-mt8196-ufs_ao.c | 109 +++++++++++++++++++++++ > 3 files changed, 117 insertions(+) > create mode 100644 drivers/clk/mediatek/clk-mt8196-ufs_ao.c > > diff --git a/drivers/clk/mediatek/Kconfig b/drivers/clk/mediatek/Kconfig > index 1e0c6f177ecd..d99c39a7f10e 100644 > --- a/drivers/clk/mediatek/Kconfig > +++ b/drivers/clk/mediatek/Kconfig > @@ -1010,6 +1010,13 @@ config COMMON_CLK_MT8196 > help > This driver supports MediaTek MT8196 basic clocks. > > +config COMMON_CLK_MT8196_UFSSYS > + tristate "Clock driver for MediaTek MT8196 ufssys" > + depends on COMMON_CLK_MT8196 > + default COMMON_CLK_MT8196 > + help > + This driver supports MediaTek MT8196 ufssys clocks. > + > config COMMON_CLK_MT8365 > tristate "Clock driver for MediaTek MT8365" > depends on ARCH_MEDIATEK || COMPILE_TEST > diff --git a/drivers/clk/mediatek/Makefile b/drivers/clk/mediatek/Makefil= e > index 8888ffd3d7ba..1a497de00846 100644 > --- a/drivers/clk/mediatek/Makefile > +++ b/drivers/clk/mediatek/Makefile > @@ -153,6 +153,7 @@ obj-$(CONFIG_COMMON_CLK_MT8195_WPESYS) +=3D clk-mt819= 5-wpe.o > obj-$(CONFIG_COMMON_CLK_MT8196) +=3D clk-mt8196-apmixedsys.o clk-mt8196-= topckgen.o \ > clk-mt8196-topckgen2.o clk-mt8196-vlpc= kgen.o \ > clk-mt8196-peri_ao.o > +obj-$(CONFIG_COMMON_CLK_MT8196_UFSSYS) +=3D clk-mt8196-ufs_ao.o > obj-$(CONFIG_COMMON_CLK_MT8365) +=3D clk-mt8365-apmixedsys.o clk-mt8365.= o > obj-$(CONFIG_COMMON_CLK_MT8365_APU) +=3D clk-mt8365-apu.o > obj-$(CONFIG_COMMON_CLK_MT8365_CAM) +=3D clk-mt8365-cam.o > diff --git a/drivers/clk/mediatek/clk-mt8196-ufs_ao.c b/drivers/clk/media= tek/clk-mt8196-ufs_ao.c > new file mode 100644 > index 000000000000..858706b3ba6f > --- /dev/null > +++ b/drivers/clk/mediatek/clk-mt8196-ufs_ao.c > @@ -0,0 +1,109 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Copyright (c) 2025 MediaTek Inc. > + * Guangjie Song > + * Copyright (c) 2025 Collabora Ltd. > + * Laura Nao > + */ > +#include > +#include Nit: add empty line here for separation. > +#include > +#include > +#include > +#include > + > +#include "clk-gate.h" > +#include "clk-mtk.h" > + > +#define MT8196_UFSAO_RST0_SET_OFFSET 0x48 > +#define MT8196_UFSAO_RST1_SET_OFFSET 0x148 > + > +static const struct mtk_gate_regs ufsao0_cg_regs =3D { > + .set_ofs =3D 0x108, > + .clr_ofs =3D 0x10c, > + .sta_ofs =3D 0x104, > +}; > + > +static const struct mtk_gate_regs ufsao1_cg_regs =3D { > + .set_ofs =3D 0x8, > + .clr_ofs =3D 0xc, > + .sta_ofs =3D 0x4, > +}; > + > +#define GATE_UFSAO0(_id, _name, _parent, _shift) { \ > + .id =3D _id, \ > + .name =3D _name, \ > + .parent_name =3D _parent, \ > + .regs =3D &ufsao0_cg_regs, \ > + .shift =3D _shift, \ > + .flags =3D CLK_OPS_PARENT_ENABLE, \ This probably doesn't work correctly, since not every clock defined below has the "ufs" clock as its parent. If the requirement is that the "ufs" clock be enabled for accessing this register, it is going to fail (badly). ChenYu > + .ops =3D &mtk_clk_gate_ops_setclr, \ > + } > + > +#define GATE_UFSAO1(_id, _name, _parent, _shift) { \ > + .id =3D _id, \ > + .name =3D _name, \ > + .parent_name =3D _parent, \ > + .regs =3D &ufsao1_cg_regs, \ > + .shift =3D _shift, \ > + .flags =3D CLK_OPS_PARENT_ENABLE, \ > + .ops =3D &mtk_clk_gate_ops_setclr, \ > + } > + > +static const struct mtk_gate ufsao_clks[] =3D { > + /* UFSAO0 */ > + GATE_UFSAO0(CLK_UFSAO_UFSHCI_UFS, "ufsao_ufshci_ufs", "ufs", 0), > + GATE_UFSAO0(CLK_UFSAO_UFSHCI_AES, "ufsao_ufshci_aes", "aes_ufsfde= ", 1), > + /* UFSAO1 */ > + GATE_UFSAO1(CLK_UFSAO_UNIPRO_TX_SYM, "ufsao_unipro_tx_sym", "clk2= 6m", 0), > + GATE_UFSAO1(CLK_UFSAO_UNIPRO_RX_SYM0, "ufsao_unipro_rx_sym0", "cl= k26m", 1), > + GATE_UFSAO1(CLK_UFSAO_UNIPRO_RX_SYM1, "ufsao_unipro_rx_sym1", "cl= k26m", 2), > + GATE_UFSAO1(CLK_UFSAO_UNIPRO_SYS, "ufsao_unipro_sys", "ufs", 3), > + GATE_UFSAO1(CLK_UFSAO_UNIPRO_SAP, "ufsao_unipro_sap", "clk26m", 4= ), > + GATE_UFSAO1(CLK_UFSAO_PHY_SAP, "ufsao_phy_sap", "clk26m", 8), > +}; > + > +static u16 ufsao_rst_ofs[] =3D { > + MT8196_UFSAO_RST0_SET_OFFSET, > + MT8196_UFSAO_RST1_SET_OFFSET > +}; > + > +static u16 ufsao_rst_idx_map[] =3D { > + [MT8196_UFSAO_RST0_UFS_MPHY] =3D 8, > + [MT8196_UFSAO_RST1_UFS_UNIPRO] =3D 1 * RST_NR_PER_BANK + 0, > + [MT8196_UFSAO_RST1_UFS_CRYPTO] =3D 1 * RST_NR_PER_BANK + 1, > + [MT8196_UFSAO_RST1_UFSHCI] =3D 1 * RST_NR_PER_BANK + 2, > +}; > + > +static const struct mtk_clk_rst_desc ufsao_rst_desc =3D { > + .version =3D MTK_RST_SET_CLR, > + .rst_bank_ofs =3D ufsao_rst_ofs, > + .rst_bank_nr =3D ARRAY_SIZE(ufsao_rst_ofs), > + .rst_idx_map =3D ufsao_rst_idx_map, > + .rst_idx_map_nr =3D ARRAY_SIZE(ufsao_rst_idx_map), > +}; > + > +static const struct mtk_clk_desc ufsao_mcd =3D { > + .clks =3D ufsao_clks, > + .num_clks =3D ARRAY_SIZE(ufsao_clks), > + .rst_desc =3D &ufsao_rst_desc, > +}; > + > +static const struct of_device_id of_match_clk_mt8196_ufs_ao[] =3D { > + { .compatible =3D "mediatek,mt8196-ufscfg-ao", .data =3D &ufsao_m= cd }, > + { /* sentinel */ } > +}; > +MODULE_DEVICE_TABLE(of, of_match_clk_mt8196_ufs_ao); > + > +static struct platform_driver clk_mt8196_ufs_ao_drv =3D { > + .probe =3D mtk_clk_simple_probe, > + .remove =3D mtk_clk_simple_remove, > + .driver =3D { > + .name =3D "clk-mt8196-ufs-ao", > + .of_match_table =3D of_match_clk_mt8196_ufs_ao, > + }, > +}; > + > +module_platform_driver(clk_mt8196_ufs_ao_drv); > +MODULE_DESCRIPTION("MediaTek MT8196 ufs_ao clocks driver"); > +MODULE_LICENSE("GPL"); > -- > 2.39.5 >