From: Chen-Yu Tsai <wens@kernel.org>
To: Ajay Gupta <ajaykuee@gmail.com>
Cc: David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
Thierry Reding <treding@nvidia.com>,
Ajay Gupta <ajayg@nvidia.com>
Subject: Re: [PATCH] net: stmmac: platform: use generic device api
Date: Fri, 17 Jan 2020 11:33:30 +0800 [thread overview]
Message-ID: <CAGb2v64hEN5=2FdxzMLfZm7RT68-+YZ70-_3fCPUyZ47C-9m1g@mail.gmail.com> (raw)
In-Reply-To: <20200116005645.14026-1-ajayg@nvidia.com>
Hi,
On Fri, Jan 17, 2020 at 2:21 AM Ajay Gupta <ajaykuee@gmail.com> wrote:
>
> From: Ajay Gupta <ajayg@nvidia.com>
>
> Use generic device api to allow reading more configuration
> parameter from both DT or ACPI based devices.
>
> Signed-off-by: Ajay Gupta <ajayg@nvidia.com>
> ---
> ACPI support related changes for dwc were reently queued [1]
> This patch is required to read more configuration parameter
> through ACPI table.
>
> [1] https://marc.info/?l=linux-netdev&m=157661974305024&w=2
>
> .../ethernet/stmicro/stmmac/stmmac_platform.c | 49 +++++++++++--------
Even after your changes, there's still a lot of DT specific code in
there, such as the MDIO device node parsing. Plus the whole thing
is wrapped in "#ifdef CONFIG_OF".
Maybe it would make more sense to split out the generic device API
parts into a separate function?
Regards
ChenYu
next prev parent reply other threads:[~2020-01-17 3:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-16 0:56 [PATCH] net: stmmac: platform: use generic device api Ajay Gupta
2020-01-17 3:33 ` Chen-Yu Tsai [this message]
2020-01-17 18:28 ` Ajay Gupta
2020-01-17 8:29 ` Jose Abreu
2020-01-17 18:28 ` Ajay Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGb2v64hEN5=2FdxzMLfZm7RT68-+YZ70-_3fCPUyZ47C-9m1g@mail.gmail.com' \
--to=wens@kernel.org \
--cc=ajayg@nvidia.com \
--cc=ajaykuee@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).