From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63AF9C33C9E for ; Fri, 17 Jan 2020 03:33:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2F61A2077B for ; Fri, 17 Jan 2020 03:33:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579232024; bh=4Ffa54piw5frE9/sLOsztZ+V22ux5QW/TVxav8XeBoU=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=j/4ihypnsVfJQN9YswixVyxDUfxHNK7aVugkP48qpq5wK2RrjWIaa+V+Z1FW3MErN cp/4D3/GGGkZTYr2V07cYwTLmgA0GfJR4HO4WEbTO2tIBylMe/c0NySucXu/W8FVY0 K4xpfc7CxeFqSRPukPcbHs/fa/pZz+x5+7r4bo3I= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729499AbgAQDdn (ORCPT ); Thu, 16 Jan 2020 22:33:43 -0500 Received: from mail.kernel.org ([198.145.29.99]:34074 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727065AbgAQDdm (ORCPT ); Thu, 16 Jan 2020 22:33:42 -0500 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E168B2083E for ; Fri, 17 Jan 2020 03:33:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579232022; bh=4Ffa54piw5frE9/sLOsztZ+V22ux5QW/TVxav8XeBoU=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=dNxkj6TaZHfDKz2w61DB2BsE7Hr+a3WZ/WRuOznInthUpu/aMzydE+il4q3eztaHZ uh/XkdVXm5d6ZzdqZ8XJ1TLt3OKk7H+3+FaDuu0NJ1O/GdAWWe4D6pujVirOyeHlHr npTNd4qpH571YFihmUUAz+xPWZb3TY5BCG4xL0uQ= Received: by mail-wm1-f46.google.com with SMTP id f129so6079525wmf.2 for ; Thu, 16 Jan 2020 19:33:41 -0800 (PST) X-Gm-Message-State: APjAAAUxjwYhUykbXsm5NxD2C0h4Vxgx+qa1kwYHZx+JzYbnySPilP8L V2qD0cQ5utdMnUc2P8E0ST4bxU9oCB8zWHNUUVo= X-Google-Smtp-Source: APXvYqyxhY0xUdQ0kbquK/JIWiKm+mqwoI6dikSE5UxcCT0vrGjLP8OOhZfcRDY4FFrW78eVh6xZmWiG2IrAhmrJ0uc= X-Received: by 2002:a1c:44d5:: with SMTP id r204mr2229397wma.122.1579232020382; Thu, 16 Jan 2020 19:33:40 -0800 (PST) MIME-Version: 1.0 References: <20200116005645.14026-1-ajayg@nvidia.com> In-Reply-To: <20200116005645.14026-1-ajayg@nvidia.com> From: Chen-Yu Tsai Date: Fri, 17 Jan 2020 11:33:30 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] net: stmmac: platform: use generic device api To: Ajay Gupta Cc: David Miller , netdev , Thierry Reding , Ajay Gupta Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi, On Fri, Jan 17, 2020 at 2:21 AM Ajay Gupta wrote: > > From: Ajay Gupta > > Use generic device api to allow reading more configuration > parameter from both DT or ACPI based devices. > > Signed-off-by: Ajay Gupta > --- > ACPI support related changes for dwc were reently queued [1] > This patch is required to read more configuration parameter > through ACPI table. > > [1] https://marc.info/?l=linux-netdev&m=157661974305024&w=2 > > .../ethernet/stmicro/stmmac/stmmac_platform.c | 49 +++++++++++-------- Even after your changes, there's still a lot of DT specific code in there, such as the MDIO device node parsing. Plus the whole thing is wrapped in "#ifdef CONFIG_OF". Maybe it would make more sense to split out the generic device API parts into a separate function? Regards ChenYu