From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joachim Eastwood Subject: Re: [PATCH RFC 0/2] stmmac: stand alone platform drivers Date: Tue, 12 May 2015 22:31:11 +0200 Message-ID: References: <1431022765-30715-1-git-send-email-manabian@gmail.com> <5987007.lq0DjS0tE0@wuerfel> <5948526.xNXlKiLpxq@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: "linux-arm-kernel@lists.infradead.org" , "peppe.cavallaro" , "David S. Miller" , netdev@vger.kernel.org To: Arnd Bergmann Return-path: Received: from mail-la0-f46.google.com ([209.85.215.46]:35868 "EHLO mail-la0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752621AbbELUbN (ORCPT ); Tue, 12 May 2015 16:31:13 -0400 Received: by lagv1 with SMTP id v1so14787155lag.3 for ; Tue, 12 May 2015 13:31:11 -0700 (PDT) In-Reply-To: <5948526.xNXlKiLpxq@wuerfel> Sender: netdev-owner@vger.kernel.org List-ID: On 12 May 2015 at 21:49, Arnd Bergmann wrote: > On Tuesday 12 May 2015 19:20:45 Joachim Eastwood wrote: >> >> I have now created a generic dt dwmac driver which contain all compat >> strings that doesn't have any match data. As long as this driver is >> linked last this works for my built-in drivers configuration. I am not >> able to test using modules because of my very limited rootfs. This is >> a Cortex-M system after all. >> >> I also converted all the other DT dwmac drivers and the entire patch >> set can be found on: >> https://github.com/manabian/linux-lpc >> >> After I have done some more cleanups and added proper commit messages >> I will put them on netdev again. >> >> > > Yes, this looks really nice (with the cleanup bits that are obviously > missing applied), thanks a lot! > > We should probably try to keep existing defconfig files working, > which could be done e.g. like > > config DWMAC_ROCKCHIP > tristate "Rockchip dwmac support" > + default ARCH_ROCKCHIP > depends on OF > select MFD_SYSCON > > so that any configuration that currently has ARCH_ROCKCHIP and DW_MAC > enabled ends up with DWMAC_ROCKCHIP enabled as well. Ah, yes, indeed. I will add a default statement in the Kconfig of the converted drivers. regards, Joachim Eastwood