From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yegor Yefremov Subject: Re: [PATCH] net: phy: Add support for SMSC/Microchip LAN9303 3-port switch Date: Wed, 12 Mar 2014 09:43:03 +0100 Message-ID: References: <531057A4.5020607@denx.de> <20140228.130020.2022765291621434648.davem@davemloft.net> <20140311.163924.934541574802061078.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: Stefan Roese , netdev , "r.meier" , "lukas.stockmann" , Florian Fainelli To: David Miller Return-path: Received: from mail-pb0-f46.google.com ([209.85.160.46]:50364 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752193AbaCLInX (ORCPT ); Wed, 12 Mar 2014 04:43:23 -0400 Received: by mail-pb0-f46.google.com with SMTP id rq2so783681pbb.19 for ; Wed, 12 Mar 2014 01:43:23 -0700 (PDT) In-Reply-To: <20140311.163924.934541574802061078.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, Mar 11, 2014 at 9:39 PM, David Miller wrote: > From: Yegor Yefremov > Date: Tue, 11 Mar 2014 21:11:16 +0100 > >> On Fri, Feb 28, 2014 at 7:00 PM, David Miller wrote: >>> From: Stefan Roese >>> Date: Fri, 28 Feb 2014 10:32:20 +0100 >>> >>>> On 27.02.2014 23:02, David Miller wrote: >>>>> From: Stefan Roese >>>>> Date: Thu, 27 Feb 2014 10:07:52 +0100 >>>>> >>>>> Better is to come up with a real, types, interface for programming >>>>> such devices and providing an implementation of that. >>>> >>>> Right. Such a thing would be better. But as Florian already pointed >>>> out, nothing like this is available in kernel.org right now. Thats the >>>> reason why I chose to implement this "simple" driver, btw as done in >>>> drivers/net/phy/spi_ks8995.c. >>> >>> When a suitable user facing interface is lacking, you create one >>> and submit it for review here. You don't just submit adhoc driver >>> local stuff. >> >> David, what about enabling ethtool to read/write from/to the PHY >> registers (via passing PHY ID and register number)? I'm trying to get >> ICplus IP175D running and it has lots of registers, that I would like >> to look at dynamically. > > For debugging, register dumps are already supported by ethtool. Do you mean 'ethtool -e' option? AFAIK it dumps Ethernet controller regs, if it implements ethtool_ops.get_regs(). What I need are PHY registers, that I can get via MII interface. ethtool should provide access to PHY registers like mdiobus_read() and mdiobus_write() routines. Another option were to add get_regs() to 'struct phy_driver', but in this case one won't be able to write to the registers. Yegor