From: Sven Van Asbroeck <thesven73@gmail.com>
To: Bryan Whitehead <Bryan.Whitehead@microchip.com>
Cc: "Microchip Linux Driver Support" <UNGLinuxDriver@microchip.com>,
"David Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>,
"Andrew Lunn" <andrew@lunn.ch>,
"Alexey Denisov" <rtgbnm@gmail.com>,
"Sergej Bauer" <sbauer@blackbox.su>,
"Tim Harvey" <tharvey@gateworks.com>,
"Anders Rønningen" <anders@ronningen.priv.no>,
netdev <netdev@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next v1 1/6] lan743x: boost performance on cpu archs w/o dma cache snooping
Date: Sat, 30 Jan 2021 19:14:16 -0500 [thread overview]
Message-ID: <CAGngYiX-bccoqYW0zQDwseBPADK-eNEcMDA1mhPqQvQC6FS3qQ@mail.gmail.com> (raw)
In-Reply-To: <MN2PR11MB3662C6C13B2D549E339D7DD1FAB89@MN2PR11MB3662.namprd11.prod.outlook.com>
On Sat, Jan 30, 2021 at 5:11 PM <Bryan.Whitehead@microchip.com> wrote:
>
> It appears you moved this packet_length assignment from just below the following if block, however you left out the le32_to_cpu.See next comment
PS this merge snafu is removed completely by the next patch in the set.
So this will not prevent you from reviewing/testing the multi-buffer support,
should you want to.
next prev parent reply other threads:[~2021-01-31 0:15 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-29 19:52 [PATCH net-next v1 0/6] lan743x speed boost Sven Van Asbroeck
2021-01-29 19:52 ` [PATCH net-next v1 1/6] lan743x: boost performance on cpu archs w/o dma cache snooping Sven Van Asbroeck
2021-01-29 20:36 ` Andrew Lunn
2021-01-29 22:49 ` Sven Van Asbroeck
2021-01-29 22:01 ` Jakub Kicinski
2021-01-29 22:46 ` Sven Van Asbroeck
2021-01-30 22:10 ` Bryan.Whitehead
2021-01-30 23:59 ` Sven Van Asbroeck
2021-01-31 0:14 ` Sven Van Asbroeck [this message]
[not found] ` <20210204060210.2362-1-hdanton@sina.com>
2021-02-05 9:31 ` Christoph Hellwig
2021-02-05 14:01 ` Sven Van Asbroeck
2021-02-05 12:44 ` Sergej Bauer
2021-02-05 14:07 ` Sven Van Asbroeck
2021-02-05 15:09 ` Sergej Bauer
2021-02-05 16:39 ` Sven Van Asbroeck
2021-02-05 16:59 ` Sergej Bauer
2021-01-29 19:52 ` [PATCH net-next v1 2/6] lan743x: support rx multi-buffer packets Sven Van Asbroeck
2021-01-29 22:11 ` Willem de Bruijn
2021-01-29 23:02 ` Sven Van Asbroeck
2021-01-29 23:08 ` Willem de Bruijn
2021-01-29 23:10 ` Sven Van Asbroeck
2021-01-31 7:06 ` Bryan.Whitehead
2021-01-31 15:25 ` Sven Van Asbroeck
2021-02-01 18:04 ` Bryan.Whitehead
2021-02-03 18:53 ` Sven Van Asbroeck
2021-02-03 20:14 ` Bryan.Whitehead
2021-02-03 20:25 ` Sven Van Asbroeck
2021-02-03 20:41 ` Bryan.Whitehead
2021-01-29 19:52 ` [PATCH net-next v1 3/6] lan743x: allow mtu change while network interface is up Sven Van Asbroeck
2021-01-29 19:52 ` [PATCH net-next v1 4/6] TEST ONLY: lan743x: limit rx ring buffer size to 500 bytes Sven Van Asbroeck
2021-01-29 19:52 ` [PATCH net-next v1 5/6] TEST ONLY: lan743x: skb_alloc failure test Sven Van Asbroeck
2021-01-29 19:52 ` [PATCH net-next v1 6/6] TEST ONLY: lan743x: skb_trim " Sven Van Asbroeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGngYiX-bccoqYW0zQDwseBPADK-eNEcMDA1mhPqQvQC6FS3qQ@mail.gmail.com \
--to=thesven73@gmail.com \
--cc=Bryan.Whitehead@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=anders@ronningen.priv.no \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rtgbnm@gmail.com \
--cc=sbauer@blackbox.su \
--cc=tharvey@gateworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).