From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8CAE66AC2 for ; Fri, 14 Jul 2023 06:09:29 +0000 (UTC) Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 22213271F for ; Thu, 13 Jul 2023 23:09:27 -0700 (PDT) Received: by mail-lj1-x22a.google.com with SMTP id 38308e7fff4ca-2b703cbfaf5so22605251fa.1 for ; Thu, 13 Jul 2023 23:09:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shruggie-ro.20221208.gappssmtp.com; s=20221208; t=1689314965; x=1691906965; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=orndSSj2UwJllcFmURUAszpsDxToWW+bTCSrpDuMB50=; b=rSEucAgbUYeHVSTSXbX4h9GDYS7AeA8YfypaK3t0f6sWPqzBWQ/QvuRZTL8H2O6J1X zaZ2wmQb0KGIHIikVtnGAD1g4DfHldSNxbhWr1jKDz1mauD7+5RnWspMa4fLwtvagkMK wRPzB99gpXTCYAWWelL1AcWzOUjnPSspm6YWQhRlL9KARAvHdzc3c+bjQxEL7q/L52cq EFU9PekimSQVQl5N0LgDJ1Sdsh+D3Yr39lZpEq+etM8KnUCAHoKLdW8QGrTMFcQc13/3 TO1Mw4QglCtfnsDEfqJ7KGed8AxkbcPl129VsMSxvmn84pht1j7uG9ZJW9Z5Xat/cyoR N7tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689314965; x=1691906965; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=orndSSj2UwJllcFmURUAszpsDxToWW+bTCSrpDuMB50=; b=S/r6S2uh1PWsbmfE0Tf+0cVKOCFv79CzwYLzPEQNueXlM4yLZIa3adTXhGW10yVrOM weQFovJ27WEvt6B0G0VcEts82gbTG7ES0m8Mqlta0qAUG3aEAOJkitExancZbPs51+0B hKFQfeqi0nm1CSzGMdIabgUxe94T8sotlbih4s5m35s4PR0Vx5ZBDDGbS+9xnEAFPCMj FOGD+IrMKl1C2CF34y03QQeZyzluSwg+bsCHqc7gxRTicgppgp4srj0ycFS0MV/+uCf0 zyu0Z2IiUdJ0FKzpfVWyGjiHFhp+Ip8z0mHm7qmbioHe+N0m4tJo5WE4roExjKVUkQ8+ TF1Q== X-Gm-Message-State: ABy/qLZ23Hxtj1ggOpBdGn27iDylfDbM+kFyioPWghZ4hLW6aio7kp3e 4/YDWSonZAm1FWFUQMg7RIAXws8NAvKODNfc6lZZsg== X-Google-Smtp-Source: APBJJlFjLd9SWBhGndhtxU1nyRlXyT203Tkpfb7Enzl8TGvLVxH8C8IUB34raRw1SX1qPqj8h/XE/oW4vWlS8LF/62A= X-Received: by 2002:a2e:9284:0:b0:2b5:8a21:5627 with SMTP id d4-20020a2e9284000000b002b58a215627mr3394159ljh.51.1689314965292; Thu, 13 Jul 2023 23:09:25 -0700 (PDT) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20230713202123.231445-1-alex@shruggie.ro> In-Reply-To: From: Alexandru Ardelean Date: Fri, 14 Jul 2023 09:09:14 +0300 Message-ID: Subject: Re: [PATCH v2 1/2 net-next] net: phy: mscc: add support for CLKOUT ctrl reg for VSC8531 and similar To: Andrew Lunn Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, hkallweit1@gmail.com, linux@armlinux.org.uk, olteanv@gmail.com, marius.muresan@mxt.ro Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On Thu, Jul 13, 2023 at 11:35=E2=80=AFPM Andrew Lunn wrote= : > > > +set_reg: > > + mutex_lock(&phydev->lock); > > + rc =3D phy_modify_paged(phydev, MSCC_PHY_PAGE_EXTENDED_GPIO, > > + VSC8531_CLKOUT_CNTL, mask, set); > > + mutex_unlock(&phydev->lock); > > What is this mutex protecting? This was inspired by vsc85xx_edge_rate_cntl_set(). Which has the same format. I'll re-test with this lock removed. I may be misremembering (or maybe I did something silly at some point), but there was a weird stack-trace warning before adding this lock there. This was with a 5.10.116 kernel version. > > Andrew