From: Cong Wang <cwang@twopensource.com>
To: David Miller <davem@davemloft.net>
Cc: Eric Dumazet <eric.dumazet@gmail.com>, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net] net-gro: reset skb->truesize in napi_reuse_skb()
Date: Fri, 16 May 2014 14:27:00 -0700 [thread overview]
Message-ID: <CAHA+R7MZEHhqLrxdcp-M3pWEC_wVkm5W5v8HUDSc_w10HYg5aQ@mail.gmail.com> (raw)
In-Reply-To: <20140403.161834.1232262926542795326.davem@davemloft.net>
On Thu, Apr 3, 2014 at 1:18 PM, David Miller <davem@davemloft.net> wrote:
> From: Eric Dumazet <eric.dumazet@gmail.com>
> Date: Thu, 03 Apr 2014 09:28:10 -0700
>
>> From: Eric Dumazet <edumazet@google.com>
>>
>> Recycling skb always had been very tough...
>>
>> This time it appears GRO layer can accumulate skb->truesize
>> adjustments made by drivers when they attach a fragment to skb.
>>
>> skb_gro_receive() can only subtract from skb->truesize the used part
>> of a fragment.
>>
>> I spotted this problem seeing TcpExtPruneCalled and
>> TcpExtTCPRcvCollapsed that were unexpected with a recent kernel, where
>> TCP receive window should be sized properly to accept traffic coming
>> from a driver not overshooting skb->truesize.
>>
>> Signed-off-by: Eric Dumazet <edumazet@google.com>
>
> Nasty...
>
> Applied, thanks Eric.
I think this patch should be queued for -stable as well?
Looking at your stable queue [1], it's not there. :)
Thanks!
1. http://patchwork.ozlabs.org/bundle/davem/stable/?state=*
prev parent reply other threads:[~2014-05-16 21:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-03 16:28 [PATCH net] net-gro: reset skb->truesize in napi_reuse_skb() Eric Dumazet
2014-04-03 20:18 ` David Miller
2014-05-16 21:27 ` Cong Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHA+R7MZEHhqLrxdcp-M3pWEC_wVkm5W5v8HUDSc_w10HYg5aQ@mail.gmail.com \
--to=cwang@twopensource.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).