netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Cong Wang <cwang@twopensource.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Wengang <wen.gang.wang@oracle.com>, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH] bonding: clear header_ops when last slave detached (v2)
Date: Thu, 20 Nov 2014 13:57:00 -0800	[thread overview]
Message-ID: <CAHA+R7Me4zPdGpeQVHFLLGVq=4cVar09jQFyjA81nxF_Fmuppw@mail.gmail.com> (raw)
In-Reply-To: <1416516104.8629.39.camel@edumazet-glaptop2.roam.corp.google.com>

On Thu, Nov 20, 2014 at 12:41 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
> On Thu, 2014-11-20 at 09:34 -0800, Cong Wang wrote:
>
>> I didn't look into ipoib_header_ops, thought it might have some dependency
>> on symbols.
>
> I did look before answering and suggesting this, you really should do
> the same instead of giving advices of over engineering the stack.
>
> Best is the enemy of the good.
>
> Its hard to find some networking function trivial than this one.

What about other modules defining *header_ops? Don't they
need to move to vmlinux as well?

I still don't like this workaround even just for stable. Although
definitely a real fix could be harder to backport, for me it is normal
backport 8+ patches to stable:

http://www.spinics.net/lists/stable/msg66122.html
http://www.spinics.net/lists/linux-fsdevel/msg79967.html

I know you disagree, I don't even want to waste time on arguing it.

  reply	other threads:[~2014-11-20 21:57 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-19  5:18 [PATCH] bonding: clear header_ops when last slave detached (v2) Wengang Wang
2014-11-19  5:22 ` Wengang
2014-11-19  5:39 ` Eric Dumazet
2014-11-19  7:00   ` Wengang
2014-11-19 22:26     ` Cong Wang
2014-11-19 22:56       ` Cong Wang
2014-11-20  6:41       ` Eric Dumazet
2014-11-20 17:34         ` Cong Wang
2014-11-20 20:41           ` Eric Dumazet
2014-11-20 21:57             ` Cong Wang [this message]
2014-11-20 22:03               ` Eric Dumazet
2014-11-20 22:13                 ` Cong Wang
2014-11-20 22:53                   ` Jay Vosburgh
2014-11-21 18:17                     ` Cong Wang
2014-11-21 18:54                       ` Jay Vosburgh
2014-11-24  3:05                         ` Wengang
2014-11-21 18:55                       ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHA+R7Me4zPdGpeQVHFLLGVq=4cVar09jQFyjA81nxF_Fmuppw@mail.gmail.com' \
    --to=cwang@twopensource.com \
    --cc=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=wen.gang.wang@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).