From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cong Wang Subject: Re: [PATCH] bridge: only provide proxy ARP when CONFIG_INET is enabled Date: Tue, 13 Jan 2015 11:25:45 -0800 Message-ID: References: <56868207.rHBDZL3pbk@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: netdev , Kyeyoon Park , "bridge@lists.linux-foundation.org" , David Miller To: Arnd Bergmann Return-path: In-Reply-To: <56868207.rHBDZL3pbk@wuerfel> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: bridge-bounces@lists.linux-foundation.org Errors-To: bridge-bounces@lists.linux-foundation.org List-Id: netdev.vger.kernel.org On Tue, Jan 13, 2015 at 6:10 AM, Arnd Bergmann wrote: > When IPV4 support is disabled, we cannot call arp_send from > the bridge code, which would result in a kernel link error: > > net/built-in.o: In function `br_handle_frame_finish': > :(.text+0x59914): undefined reference to `arp_send' > :(.text+0x59a50): undefined reference to `arp_tbl' > > This makes the newly added proxy ARP support in the bridge > code depend on the CONFIG_INET symbol and lets the compiler > optimize the code out to avoid the link error. > Not sure how much sense to make CONFIG_BRIDGE depend on CONFIG_INET, at least CONFIG_BONDING does.