From: Cong Wang <cwang@twopensource.com>
To: Ani Sinha <ani@arista.com>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
David Miller <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: route/max_size sysctl in ipv4
Date: Fri, 9 Jan 2015 11:37:42 -0800 [thread overview]
Message-ID: <CAHA+R7Pi=87b_umrKnd4bsZ+DPkRoTWhNyPwAND5pDzF_3EDaQ@mail.gmail.com> (raw)
In-Reply-To: <CAOxq_8Na14ES1souk-jBa8A=9ArHc-ffRtSd36zbvwHvGM+24Q@mail.gmail.com>
On Fri, Jan 9, 2015 at 11:08 AM, Ani Sinha <ani@arista.com> wrote:
>
> Perhaps. What I am truly confused about is :
>
> - We are keeping a sysctl interface that does absolutely nothing in
> the kernel and is completely useless in case some userland
> scripts/tools are rendered broken from it's removal.
I am all for getting rid of it, sane script should always check
the sysctl existence first. I think we did remove some sysctl's
from kernel before.
>
> - surprisingly, we contradict ourselves when we let scripts break when
> running from a child namespace because the same sysctl is no longer
> available!
>
I am not sure how exactly your script is broken, but it should
test the existence of any /proc file before reading it, even when
you don't use netns, because this could be a new sysctl introduced
recently (probably not the case for ip_rt_max_size, but you get my point).
next prev parent reply other threads:[~2015-01-09 19:37 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-05 23:48 route/max_size sysctl in ipv4 Ani Sinha
2015-01-06 0:36 ` David Miller
2015-01-06 0:43 ` Ani Sinha
2015-01-06 0:51 ` David Miller
2015-01-06 0:56 ` Ani Sinha
2015-01-06 12:41 ` Pádraig Brady
2015-01-06 17:11 ` Ani Sinha
2015-01-06 18:09 ` Eric Dumazet
2015-01-06 20:05 ` Ani Sinha
2015-01-07 1:56 ` Ani Sinha
2015-01-08 1:25 ` Ani Sinha
2015-01-08 2:19 ` Eric Dumazet
2015-01-08 3:40 ` Ani Sinha
2015-01-08 5:41 ` Eric Dumazet
2015-01-08 18:39 ` Ani Sinha
2015-01-08 19:03 ` Eric Dumazet
2015-01-08 20:13 ` Ani Sinha
2015-01-08 20:18 ` Eric Dumazet
2015-01-09 18:47 ` Cong Wang
2015-01-09 19:08 ` Ani Sinha
2015-01-09 19:37 ` Cong Wang [this message]
2015-01-09 21:23 ` Ani Sinha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHA+R7Pi=87b_umrKnd4bsZ+DPkRoTWhNyPwAND5pDzF_3EDaQ@mail.gmail.com' \
--to=cwang@twopensource.com \
--cc=ani@arista.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).