From: Mina Almasry <almasrymina@google.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
tariqt@nvidia.com, dtatulea@nvidia.com, hawk@kernel.org,
ilias.apalodimas@linaro.org, alexanderduyck@fb.com,
sdf@fomichev.me
Subject: Re: [PATCH net-next v2 10/14] net: add helper to pre-check if PP for an Rx queue will be unreadable
Date: Fri, 29 Aug 2025 14:56:06 -0700 [thread overview]
Message-ID: <CAHS8izMh4O+U1p84TnxS2cLhyyG=gMy_yo0U09x=NYYzEHYe-A@mail.gmail.com> (raw)
In-Reply-To: <20250829012304.4146195-11-kuba@kernel.org>
On Thu, Aug 28, 2025 at 6:23 PM Jakub Kicinski <kuba@kernel.org> wrote:
>
> mlx5 pokes into the rxq state to check if the queue has a memory
> provider, and therefore whether it may produce unreadable mem.
> Add a helper for doing this in the page pool API. fbnic will want
> a similar thing (tho, for a slightly different reason).
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Mina Almasry <almasrymina@google.com>
Only thing is I wonder if we need to ASSERT_RTNL (or the netdev
instance lock equivalent) in the helper to catch data races around
setting/querying mp_ops in future code, but we already don't do that
in existing code and it's not worth the hassle.
--
Thanks,
Mina
next prev parent reply other threads:[~2025-08-29 21:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-29 1:22 [PATCH net-next v2 00/14] eth: fbnic: support queue API and zero-copy Rx Jakub Kicinski
2025-08-29 1:22 ` [PATCH net-next v2 01/14] eth: fbnic: move page pool pointer from NAPI to the ring struct Jakub Kicinski
2025-08-29 1:22 ` [PATCH net-next v2 02/14] eth: fbnic: move xdp_rxq_info_reg() to resource alloc Jakub Kicinski
2025-08-29 1:22 ` [PATCH net-next v2 03/14] eth: fbnic: move page pool alloc to fbnic_alloc_rx_qt_resources() Jakub Kicinski
2025-08-29 1:22 ` [PATCH net-next v2 04/14] eth: fbnic: use netmem_ref where applicable Jakub Kicinski
2025-08-29 1:22 ` [PATCH net-next v2 05/14] eth: fbnic: request ops lock Jakub Kicinski
2025-08-29 1:22 ` [PATCH net-next v2 06/14] eth: fbnic: split fbnic_disable() Jakub Kicinski
2025-08-29 1:22 ` [PATCH net-next v2 07/14] eth: fbnic: split fbnic_flush() Jakub Kicinski
2025-08-29 1:22 ` [PATCH net-next v2 08/14] eth: fbnic: split fbnic_enable() Jakub Kicinski
2025-08-29 1:22 ` [PATCH net-next v2 09/14] eth: fbnic: split fbnic_fill() Jakub Kicinski
2025-08-29 1:23 ` [PATCH net-next v2 10/14] net: add helper to pre-check if PP for an Rx queue will be unreadable Jakub Kicinski
2025-08-29 21:56 ` Mina Almasry [this message]
2025-08-29 1:23 ` [PATCH net-next v2 11/14] eth: fbnic: allocate unreadable page pool for the payloads Jakub Kicinski
2025-08-29 1:23 ` [PATCH net-next v2 12/14] eth: fbnic: defer page pool recycling activation to queue start Jakub Kicinski
2025-08-29 21:57 ` Mina Almasry
2025-08-29 1:23 ` [PATCH net-next v2 13/14] eth: fbnic: don't pass NAPI into pp alloc Jakub Kicinski
2025-08-29 1:23 ` [PATCH net-next v2 14/14] eth: fbnic: support queue ops / zero-copy Rx Jakub Kicinski
2025-08-29 22:09 ` Mina Almasry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHS8izMh4O+U1p84TnxS2cLhyyG=gMy_yo0U09x=NYYzEHYe-A@mail.gmail.com' \
--to=almasrymina@google.com \
--cc=alexanderduyck@fb.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=dtatulea@nvidia.com \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=horms@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).