From: Catherine Sullivan <csully@google.com>
To: David Miller <davem@davemloft.net>
Cc: chuhongyuan@outlook.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gve: replace kfree with kvfree
Date: Fri, 19 Jul 2019 10:44:54 -0700 [thread overview]
Message-ID: <CAH_-1qwjgoi7Yve0s1NS1oEKXmxu3V5SPZMzy-Wwux-gM0Pf+Q@mail.gmail.com> (raw)
In-Reply-To: <20190718.163207.289099133864098969.davem@davemloft.net>
On Thu, Jul 18, 2019 at 4:32 PM David Miller <davem@davemloft.net> wrote:
>
> From: Chuhong YUAN <chuhongyuan@outlook.com>
> Date: Wed, 17 Jul 2019 00:59:02 +0000
>
> > Variables allocated by kvzalloc should not be freed by kfree.
> > Because they may be allocated by vmalloc.
> > So we replace kfree with kvfree here.
> >
> > Signed-off-by: Chuhong Yuan <chuhongyuan@outlook.com>
>
> Applied, thanks Chuhong.
>
> GVE maintainers, you are upstream now and have to stay on top of review
> of changes like this. Otherwise I'll just review it myself and apply
> it unless I find problems, and that may not be what you want :)
Will do, thanks for the review. And thanks for the fix Chuhong.
next prev parent reply other threads:[~2019-07-19 17:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <MWHPR11MB1757F23147F85B59BCF1628BAFC90@MWHPR11MB1757.namprd11.prod.outlook.com>
2019-07-18 23:32 ` [PATCH] gve: replace kfree with kvfree David Miller
2019-07-19 17:44 ` Catherine Sullivan [this message]
2019-07-17 2:05 Chuhong Yuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAH_-1qwjgoi7Yve0s1NS1oEKXmxu3V5SPZMzy-Wwux-gM0Pf+Q@mail.gmail.com \
--to=csully@google.com \
--cc=chuhongyuan@outlook.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).