From: Andy Gospodarek <andy@greyhouse.net>
To: Jiri Pirko <jiri@resnulli.us>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
David Miller <davem@davemloft.net>,
idosch@mellanox.com, eladr@mellanox.com, yotamg@mellanox.com,
nogahf@mellanox.com, ogerlitz <ogerlitz@mellanox.com>,
Roopa Prabhu <roopa@cumulusnetworks.com>,
nikolay@cumulusnetworks.com,
"John W. Linville" <linville@tuxdriver.com>,
Florian Fainelli <f.fainelli@gmail.com>,
dsa@cumulusnetworks.com, Jamal Hadi Salim <jhs@mojatatu.com>,
vivien.didelot@savoirfairelinux.com, andrew@lunn.ch,
ivecera@redhat.com, nicolas.dichtel@6wind.com
Subject: Re: [patch net] rtnetlink: Add rtnexthop offload flag to compare mask
Date: Tue, 18 Oct 2016 22:26:03 -0400 [thread overview]
Message-ID: <CAHashqADC-8qsYC0puUruV2sCQp-5SUXm7bMAUJQZ3pUEJZPbg@mail.gmail.com> (raw)
In-Reply-To: <1476809974-14707-1-git-send-email-jiri@resnulli.us>
On Tue, Oct 18, 2016 at 12:59 PM, Jiri Pirko <jiri@resnulli.us> wrote:
> From: Jiri Pirko <jiri@mellanox.com>
>
> The offload flag is a status flag and should not be used by
> FIB semantics for comparison.
This is definitely needed.
>
> Fixes: 37ed9493699c ("rtnetlink: add RTNH_F_EXTERNAL flag for fib offload")
> Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Reviewed-by: Andy Gospodarek <andy@greyhouse.net>
> ---
> Please queue-up to stable as well. Thanks.
> ---
> include/uapi/linux/rtnetlink.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/uapi/linux/rtnetlink.h b/include/uapi/linux/rtnetlink.h
> index 262f037..5a78be5 100644
> --- a/include/uapi/linux/rtnetlink.h
> +++ b/include/uapi/linux/rtnetlink.h
> @@ -350,7 +350,7 @@ struct rtnexthop {
> #define RTNH_F_OFFLOAD 8 /* offloaded route */
> #define RTNH_F_LINKDOWN 16 /* carrier-down on nexthop */
>
> -#define RTNH_COMPARE_MASK (RTNH_F_DEAD | RTNH_F_LINKDOWN)
> +#define RTNH_COMPARE_MASK (RTNH_F_DEAD | RTNH_F_LINKDOWN | RTNH_F_OFFLOAD)
>
> /* Macros to handle hexthops */
>
> --
> 2.5.5
>
next prev parent reply other threads:[~2016-10-19 2:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-18 16:59 [patch net] rtnetlink: Add rtnexthop offload flag to compare mask Jiri Pirko
2016-10-19 2:26 ` Andy Gospodarek [this message]
2016-10-19 15:08 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHashqADC-8qsYC0puUruV2sCQp-5SUXm7bMAUJQZ3pUEJZPbg@mail.gmail.com \
--to=andy@greyhouse.net \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dsa@cumulusnetworks.com \
--cc=eladr@mellanox.com \
--cc=f.fainelli@gmail.com \
--cc=idosch@mellanox.com \
--cc=ivecera@redhat.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=nikolay@cumulusnetworks.com \
--cc=nogahf@mellanox.com \
--cc=ogerlitz@mellanox.com \
--cc=roopa@cumulusnetworks.com \
--cc=vivien.didelot@savoirfairelinux.com \
--cc=yotamg@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).