* [patch net] rtnetlink: Add rtnexthop offload flag to compare mask
@ 2016-10-18 16:59 Jiri Pirko
2016-10-19 2:26 ` Andy Gospodarek
2016-10-19 15:08 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Jiri Pirko @ 2016-10-18 16:59 UTC (permalink / raw)
To: netdev
Cc: davem, idosch, eladr, yotamg, nogahf, ogerlitz, roopa, nikolay,
linville, andy, f.fainelli, dsa, jhs, vivien.didelot, andrew,
ivecera, nicolas.dichtel
From: Jiri Pirko <jiri@mellanox.com>
The offload flag is a status flag and should not be used by
FIB semantics for comparison.
Fixes: 37ed9493699c ("rtnetlink: add RTNH_F_EXTERNAL flag for fib offload")
Signed-off-by: Jiri Pirko <jiri@mellanox.com>
---
Please queue-up to stable as well. Thanks.
---
include/uapi/linux/rtnetlink.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/uapi/linux/rtnetlink.h b/include/uapi/linux/rtnetlink.h
index 262f037..5a78be5 100644
--- a/include/uapi/linux/rtnetlink.h
+++ b/include/uapi/linux/rtnetlink.h
@@ -350,7 +350,7 @@ struct rtnexthop {
#define RTNH_F_OFFLOAD 8 /* offloaded route */
#define RTNH_F_LINKDOWN 16 /* carrier-down on nexthop */
-#define RTNH_COMPARE_MASK (RTNH_F_DEAD | RTNH_F_LINKDOWN)
+#define RTNH_COMPARE_MASK (RTNH_F_DEAD | RTNH_F_LINKDOWN | RTNH_F_OFFLOAD)
/* Macros to handle hexthops */
--
2.5.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [patch net] rtnetlink: Add rtnexthop offload flag to compare mask
2016-10-18 16:59 [patch net] rtnetlink: Add rtnexthop offload flag to compare mask Jiri Pirko
@ 2016-10-19 2:26 ` Andy Gospodarek
2016-10-19 15:08 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Andy Gospodarek @ 2016-10-19 2:26 UTC (permalink / raw)
To: Jiri Pirko
Cc: netdev@vger.kernel.org, David Miller, idosch, eladr, yotamg,
nogahf, ogerlitz, Roopa Prabhu, nikolay, John W. Linville,
Florian Fainelli, dsa, Jamal Hadi Salim, vivien.didelot, andrew,
ivecera, nicolas.dichtel
On Tue, Oct 18, 2016 at 12:59 PM, Jiri Pirko <jiri@resnulli.us> wrote:
> From: Jiri Pirko <jiri@mellanox.com>
>
> The offload flag is a status flag and should not be used by
> FIB semantics for comparison.
This is definitely needed.
>
> Fixes: 37ed9493699c ("rtnetlink: add RTNH_F_EXTERNAL flag for fib offload")
> Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Reviewed-by: Andy Gospodarek <andy@greyhouse.net>
> ---
> Please queue-up to stable as well. Thanks.
> ---
> include/uapi/linux/rtnetlink.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/uapi/linux/rtnetlink.h b/include/uapi/linux/rtnetlink.h
> index 262f037..5a78be5 100644
> --- a/include/uapi/linux/rtnetlink.h
> +++ b/include/uapi/linux/rtnetlink.h
> @@ -350,7 +350,7 @@ struct rtnexthop {
> #define RTNH_F_OFFLOAD 8 /* offloaded route */
> #define RTNH_F_LINKDOWN 16 /* carrier-down on nexthop */
>
> -#define RTNH_COMPARE_MASK (RTNH_F_DEAD | RTNH_F_LINKDOWN)
> +#define RTNH_COMPARE_MASK (RTNH_F_DEAD | RTNH_F_LINKDOWN | RTNH_F_OFFLOAD)
>
> /* Macros to handle hexthops */
>
> --
> 2.5.5
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [patch net] rtnetlink: Add rtnexthop offload flag to compare mask
2016-10-18 16:59 [patch net] rtnetlink: Add rtnexthop offload flag to compare mask Jiri Pirko
2016-10-19 2:26 ` Andy Gospodarek
@ 2016-10-19 15:08 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2016-10-19 15:08 UTC (permalink / raw)
To: jiri
Cc: netdev, idosch, eladr, yotamg, nogahf, ogerlitz, roopa, nikolay,
linville, andy, f.fainelli, dsa, jhs, vivien.didelot, andrew,
ivecera, nicolas.dichtel
From: Jiri Pirko <jiri@resnulli.us>
Date: Tue, 18 Oct 2016 18:59:34 +0200
> From: Jiri Pirko <jiri@mellanox.com>
>
> The offload flag is a status flag and should not be used by
> FIB semantics for comparison.
>
> Fixes: 37ed9493699c ("rtnetlink: add RTNH_F_EXTERNAL flag for fib offload")
> Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Ouch, good catch.
Applied and queued up for -stable, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-10-19 15:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-18 16:59 [patch net] rtnetlink: Add rtnexthop offload flag to compare mask Jiri Pirko
2016-10-19 2:26 ` Andy Gospodarek
2016-10-19 15:08 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).