From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>, netdev <netdev@vger.kernel.org>,
Eric Dumazet <edumazet@google.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Willy Tarreau <w@1wt.eu>
Subject: Re: [PATCH net-next] once: add DO_ONCE_SLOW() for sleepable contexts
Date: Mon, 3 Oct 2022 19:43:15 +0200 [thread overview]
Message-ID: <CAHmME9oh1aFCMBeV-vvtfMoCx4N5r_tABp79tkPNNLJnc1ug7Q@mail.gmail.com> (raw)
In-Reply-To: <20221003102520.75fc51b4@kernel.org>
On Mon, Oct 3, 2022 at 7:25 PM Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Sun, 2 Oct 2022 00:44:28 +0200 Jason A. Donenfeld wrote:
> > So instead, why not just branch on whether or not we can sleep here, if
> > that can be worked out dynamically?
>
> IDK if we can dynamically work out if _all_ _possible_ callers are
> in a specific context, can we?
>
> > If not, and if you really do need two sets of macros and functions,
> > at least you can call the new one something other than "slow"? Maybe
> > something about being _SLEEPABLE() instead?
>
> +1 for s/SLOW/SLEEPABLE/. I was about to suggest s/SLOW/TASK/.
> But I guess it's already applied..
I'll send a patch to change it in a minute.
next prev parent reply other threads:[~2022-10-03 17:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-01 20:51 [PATCH net-next] once: add DO_ONCE_SLOW() for sleepable contexts Eric Dumazet
2022-10-01 21:15 ` Willy Tarreau
2022-10-01 22:50 ` Jason A. Donenfeld
2022-10-02 5:38 ` Willy Tarreau
2022-10-01 22:44 ` Jason A. Donenfeld
2022-10-01 22:50 ` Eric Dumazet
2022-10-03 17:25 ` Jakub Kicinski
2022-10-03 17:43 ` Jason A. Donenfeld [this message]
2022-10-03 18:14 ` [PATCH] once: rename _SLOW to _SLEEPABLE Jason A. Donenfeld
2022-10-03 18:14 ` [PATCH net-next] " Jason A. Donenfeld
2022-10-03 22:50 ` [PATCH] " Eric Dumazet
2022-10-02 8:58 ` [PATCH net-next] once: add DO_ONCE_SLOW() for sleepable contexts Christophe Leroy
2022-10-03 12:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHmME9oh1aFCMBeV-vvtfMoCx4N5r_tABp79tkPNNLJnc1ug7Q@mail.gmail.com \
--to=jason@zx2c4.com \
--cc=christophe.leroy@csgroup.eu \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).