From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6BE328F77 for ; Wed, 23 Aug 2023 11:51:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1D6BBC433D9; Wed, 23 Aug 2023 11:51:50 +0000 (UTC) Authentication-Results: smtp.kernel.org; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="HvlznVnN" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1692791504; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=i9S50yEi/p2rCDiQFKotCIoS/umPPt7Pl2fEpLB+hPU=; b=HvlznVnN4+nTE+9P5lkr2rPCYQplDgdO5TEv4CB+fveG2FN0HLeY+NAKhcNFA6GMXSUYPq R8vqfNV1vDE9kWFG8KCRj+3M8C/lrcTsz5tgdrIKsIZ/EgSSCfZRt8uPFm8LgCHWdCfxEV UQuclphoiHFSePfXFFvOomDkbQr3/xM= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id c56767ad (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Wed, 23 Aug 2023 11:51:44 +0000 (UTC) Received: by mail-vs1-f48.google.com with SMTP id ada2fe7eead31-44d5ac10c41so854545137.0; Wed, 23 Aug 2023 04:51:44 -0700 (PDT) X-Gm-Message-State: AOJu0YxusXUY5obDP6tjt4IEgrt6n41c6CPK6h+LdHr5QGxUrieLlpmG 5z9b6I8BK1hxlOFHEoIbSfloTkZB5DLdQUZYUqQ= X-Google-Smtp-Source: AGHT+IFt7G1/ZeusTY56LT7aeMj6tJiORTuiaRW4q76XBgQu2EncKhol2bejM2ffQ7Afv6eCg3gMogdKzIe6mnDS5dk= X-Received: by 2002:a67:ba0c:0:b0:44d:40b1:9273 with SMTP id l12-20020a67ba0c000000b0044d40b19273mr8437282vsn.4.1692791501269; Wed, 23 Aug 2023 04:51:41 -0700 (PDT) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: In-Reply-To: From: "Jason A. Donenfeld" Date: Wed, 23 Aug 2023 13:48:47 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 11/12] wireguard: Do not include crypto/algapi.h To: herbert@gondor.apana.org.au Cc: Linux Crypto Mailing List , Eric Biggers , "Theodore Y. Ts'o" , Jaegeuk Kim , linux-fscrypt@vger.kernel.org, Richard Weinberger , linux-mtd@lists.infradead.org, Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , linux-bluetooth@vger.kernel.org, Ilya Dryomov , Xiubo Li , Jeff Layton , ceph-devel@vger.kernel.org, Steffen Klassert , "David S. Miller" , netdev@vger.kernel.org, Johannes Berg , linux-wireless@vger.kernel.org, Matthieu Baerts , Mat Martineau , Chuck Lever , Neil Brown , linux-nfs@vger.kernel.org, Mimi Zohar , linux-integrity@vger.kernel.org, Ayush Sawal Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Aug 23, 2023 at 12:33=E2=80=AFPM Herbert Xu wrote: > > The header file crypto/algapi.h is for internal use only. Use the > header file crypto/utils.h instead. > > Signed-off-by: Herbert Xu > --- > > drivers/net/wireguard/cookie.c | 2 +- > drivers/net/wireguard/netlink.c | 2 +- > drivers/net/wireguard/noise.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/wireguard/cookie.c b/drivers/net/wireguard/cooki= e.c > index 4956f0499c19..f89581b5e8cb 100644 > --- a/drivers/net/wireguard/cookie.c > +++ b/drivers/net/wireguard/cookie.c > @@ -12,9 +12,9 @@ > > #include > #include > +#include > > #include > -#include > > void wg_cookie_checker_init(struct cookie_checker *checker, > struct wg_device *wg) > diff --git a/drivers/net/wireguard/netlink.c b/drivers/net/wireguard/netl= ink.c > index 6d1bd9f52d02..0a1502100e8b 100644 > --- a/drivers/net/wireguard/netlink.c > +++ b/drivers/net/wireguard/netlink.c > @@ -12,10 +12,10 @@ > > #include > > +#include > #include > #include > #include > -#include > > static struct genl_family genl_family; > > diff --git a/drivers/net/wireguard/noise.c b/drivers/net/wireguard/noise.= c > index 720952b92e78..e7ad81ca4a36 100644 > --- a/drivers/net/wireguard/noise.c > +++ b/drivers/net/wireguard/noise.c > @@ -10,12 +10,12 @@ > #include "queueing.h" > #include "peerlookup.h" > > +#include > #include > #include > #include > #include > #include > -#include > > /* This implements Noise_IKpsk2: > * Small nit - with the exception of the cookie.c reordering, could you maintain the existing #include ordering of the other files? No need to send a v2 for that if you don't want. And please make the entire commit subject lowercase. With those done, Acked-by: Jason A. Donenfeld As a side note, you may want to eventually do something to make sure people don't add back algapi.h, like move it to internal/ or out of include/ all together. I figure you've already thought about this, and this series is just the first step. Jason