From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: David Vrabel <david.vrabel@citrix.com>
Cc: Ian Campbell <ian.campbell@citrix.com>,
netdev@vger.kernel.org,
Paul McKenney <paulmck@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org, xen-devel@lists.xen.org
Subject: Re: [Xen-devel] printk from softirq on xen: hard lockup
Date: Thu, 6 Aug 2015 18:21:32 +0200 [thread overview]
Message-ID: <CAHmME9r34QsbC-RuTw40PVOD-H7zQRwvPo0gdtesyV-V05vccA@mail.gmail.com> (raw)
In-Reply-To: <55C386E9.6060806@citrix.com>
In that case, it doesn't compile.
arch/x86/xen/apic.c:204:13: error: redefinition of ‘xen_init_apic’
void __init xen_init_apic(void)
^
In file included from arch/x86/xen/apic.c:9:0:
arch/x86/xen/xen-ops.h:110:27: note: previous definition of
‘xen_init_apic’ was here
static inline void __init xen_init_apic(void)
It looks like whoever wrote this explicitly didn't want that APIC
driver used on domU:
#ifdef CONFIG_XEN_DOM0
void __init xen_init_vga(const struct dom0_vga_console_info *, size_t size);
void __init xen_init_apic(void);
#else
static inline void __init xen_init_vga(const struct dom0_vga_console_info *info,
size_t size)
{
}
static inline void __init xen_init_apic(void)
{
}
#endif
next prev parent reply other threads:[~2015-08-06 16:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-04 16:41 printk from softirq on xen: hard lockup Jason A. Donenfeld
2015-08-04 17:12 ` [Xen-devel] " David Vrabel
2015-08-04 17:45 ` Jason A. Donenfeld
2015-08-04 23:01 ` [Xen-devel] " Jason A. Donenfeld
2015-08-06 10:02 ` David Vrabel
2015-08-06 15:58 ` Jason A. Donenfeld
2015-08-06 16:10 ` David Vrabel
2015-08-06 16:21 ` Jason A. Donenfeld [this message]
2015-08-06 16:29 ` [PATCH] xen-apic: Enable on domU as well Jason A. Donenfeld
2015-08-06 16:37 ` [PATCH v2] " Jason A. Donenfeld
2015-08-07 14:23 ` [Xen-devel] " Konrad Rzeszutek Wilk
2015-08-07 14:37 ` Jason A. Donenfeld
2015-08-10 13:40 ` [PATCH v3] " Jason A. Donenfeld
2015-08-10 13:41 ` David Vrabel
2015-08-10 13:44 ` Jason A. Donenfeld
2015-08-11 10:46 ` [Xen-devel] " David Vrabel
2015-08-05 16:37 ` [Xen-devel] printk from softirq on xen: hard lockup Jason A. Donenfeld
2015-08-06 8:22 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHmME9r34QsbC-RuTw40PVOD-H7zQRwvPo0gdtesyV-V05vccA@mail.gmail.com \
--to=jason@zx2c4.com \
--cc=david.vrabel@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).