From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: roopa@cumulusnetworks.com
Cc: Netdev <netdev@vger.kernel.org>
Subject: [net regression] "fib_rules: move common handling of newrule delrule msgs into fib_nl2rule" breaks suppress_prefixlength
Date: Sat, 23 Jun 2018 17:46:46 +0200 [thread overview]
Message-ID: <CAHmME9rdxf+577u-=qx1Ss1YAz_zOPAHa6TM6ThewtybBE_R_g@mail.gmail.com> (raw)
Hey Roopa,
On a kernel with a minimal networking config,
CONFIG_IP_MULTIPLE_TABLES appears to be broken for certain rules after
f9d4b0c1e9695e3de7af3768205bacc27312320c.
Try, for example, running:
$ ip -4 rule add table main suppress_prefixlength 0
It returns with EEXIST.
Perhaps the reason is that the new rule_find function does not match
on suppress_prefixlength? However, rule_exist from before didn't do
that either. I'll keep playing and see if I can track it down myself,
but thought I should let you know first.
A relevant .config can be found at https://א.cc/iq5HoUY0
Jason
next reply other threads:[~2018-06-23 15:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-23 15:46 Jason A. Donenfeld [this message]
2018-06-23 15:59 ` [PATCH] fib_rules: match rules based on suppress_* properties too Jason A. Donenfeld
2018-06-24 2:25 ` David Miller
2018-06-25 14:58 ` Roopa Prabhu
2018-06-25 23:39 ` [PATCH v2] " Jason A. Donenfeld
2018-06-26 14:51 ` Roopa Prabhu
2018-06-27 1:34 ` David Miller
2018-06-27 4:53 ` Roopa Prabhu
2018-06-25 15:23 ` [net regression] "fib_rules: move common handling of newrule delrule msgs into fib_nl2rule" breaks suppress_prefixlength Roopa Prabhu
2018-06-25 18:36 ` Roopa Prabhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHmME9rdxf+577u-=qx1Ss1YAz_zOPAHa6TM6ThewtybBE_R_g@mail.gmail.com' \
--to=jason@zx2c4.com \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).