From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jason A. Donenfeld" Subject: [net regression] "fib_rules: move common handling of newrule delrule msgs into fib_nl2rule" breaks suppress_prefixlength Date: Sat, 23 Jun 2018 17:46:46 +0200 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Cc: Netdev To: roopa@cumulusnetworks.com Return-path: Received: from frisell.zx2c4.com ([192.95.5.64]:58369 "EHLO frisell.zx2c4.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751638AbeFWPq7 (ORCPT ); Sat, 23 Jun 2018 11:46:59 -0400 Received: by frisell.zx2c4.com (ZX2C4 Mail Server) with ESMTP id e1ca8f4d for ; Sat, 23 Jun 2018 15:40:35 +0000 (UTC) Received: by frisell.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 7c92a4eb (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128:NO) for ; Sat, 23 Jun 2018 15:40:34 +0000 (UTC) Received: by mail-ot0-f179.google.com with SMTP id a5-v6so10686073otf.12 for ; Sat, 23 Jun 2018 08:46:57 -0700 (PDT) Sender: netdev-owner@vger.kernel.org List-ID: Hey Roopa, On a kernel with a minimal networking config, CONFIG_IP_MULTIPLE_TABLES appears to be broken for certain rules after f9d4b0c1e9695e3de7af3768205bacc27312320c. Try, for example, running: $ ip -4 rule add table main suppress_prefixlength 0 It returns with EEXIST. Perhaps the reason is that the new rule_find function does not match on suppress_prefixlength? However, rule_exist from before didn't do that either. I'll keep playing and see if I can track it down myself, but thought I should let you know first. A relevant .config can be found at https://=D7=90.cc/iq5HoUY0 Jason