netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] tcp: Fix syncookies sysctl default.
@ 2016-02-08  9:25 David Miller
  2016-02-08  9:30 ` Maciej Żenczykowski
  0 siblings, 1 reply; 2+ messages in thread
From: David Miller @ 2016-02-08  9:25 UTC (permalink / raw)
  To: kernel; +Cc: netdev


Unintentionally the default was changed to zero, fix
that.

Fixes: 12ed8244ed ("ipv4: Namespaceify tcp syncookies sysctl knob")
Signed-off-by: David S. Miller <davem@davemloft.net>
---
 net/ipv4/tcp_ipv4.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c
index 11ae706..0d381fa 100644
--- a/net/ipv4/tcp_ipv4.c
+++ b/net/ipv4/tcp_ipv4.c
@@ -2389,7 +2389,7 @@ static int __net_init tcp_sk_init(struct net *net)
 
 	net->ipv4.sysctl_tcp_syn_retries = TCP_SYN_RETRIES;
 	net->ipv4.sysctl_tcp_synack_retries = TCP_SYNACK_RETRIES;
-	net->ipv4.sysctl_tcp_syncookies = 0;
+	net->ipv4.sysctl_tcp_syncookies = 1;
 	net->ipv4.sysctl_tcp_reordering = TCP_FASTRETRANS_THRESH;
 	net->ipv4.sysctl_tcp_retries1 = TCP_RETR1;
 	net->ipv4.sysctl_tcp_retries2 = TCP_RETR2;
-- 
2.5.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] tcp: Fix syncookies sysctl default.
  2016-02-08  9:25 [PATCH] tcp: Fix syncookies sysctl default David Miller
@ 2016-02-08  9:30 ` Maciej Żenczykowski
  0 siblings, 0 replies; 2+ messages in thread
From: Maciej Żenczykowski @ 2016-02-08  9:30 UTC (permalink / raw)
  To: David Miller; +Cc: kernel, Linux NetDev

Ack.  Feel free to add:

Reported-by: Maciej Żenczykowski <maze@google.com>

(via Eric Dumazet)

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-02-08  9:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-08  9:25 [PATCH] tcp: Fix syncookies sysctl default David Miller
2016-02-08  9:30 ` Maciej Żenczykowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).