From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: "Mintz, Yuval" <Yuval.Mintz@cavium.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
"David S . Miller" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Elior, Ariel" <Ariel.Elior@cavium.com>
Subject: Re: [PATCH v1 1/3] bnx2x: Replace custom scnprintf()
Date: Sun, 30 Apr 2017 15:58:18 +0300 [thread overview]
Message-ID: <CAHp75VcitfXWzUsUDthAXp97yjQQnEGND7eqSH-AFRVjH6pYDg@mail.gmail.com> (raw)
In-Reply-To: <BLUPR0701MB2004B5244F758FC95EE1B5E88D150@BLUPR0701MB2004.namprd07.prod.outlook.com>
On Sun, Apr 30, 2017 at 11:16 AM, Mintz, Yuval <Yuval.Mintz@cavium.com> wrote:
>> From: Andy Shevchenko <andy.shevchenko@gmail.com>
>>
>> Use scnprintf() when printing version instead of custom open coded variants.
>>
>> Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com>
>
> Hi Andy this seems correct.
> Was there a cover-letter for your series? I've failed to find it.
There was none since patches are quite straight forward.
> [I was mostly interested in your motivation for this kind of cleanup]
Second and third are just consequences of first one.
First one I cooked about 3 years ago after recurrent kernel checking
for code duplication (hex_to_bin() and alike).
Just now I formed as a patch and compile checked it.
> Anyway, thanks.
> Acked-by: Yuval Mintz <Yuval.Mintz@cavium.com>
Thanks.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2017-04-30 12:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-27 13:36 [PATCH v1 1/3] bnx2x: Replace custom scnprintf() Andy Shevchenko
2017-04-27 13:37 ` [PATCH v1 2/3] bnx2x: Reuse bnx2x_null_format_ver() Andy Shevchenko
2017-05-01 2:29 ` David Miller
2017-04-27 13:37 ` [PATCH v1 3/3] bnx2x: Get rid of useless temporary variable Andy Shevchenko
2017-05-01 2:29 ` David Miller
2017-04-30 8:16 ` [PATCH v1 1/3] bnx2x: Replace custom scnprintf() Mintz, Yuval
2017-04-30 12:58 ` Andy Shevchenko [this message]
2017-04-30 15:32 ` David Miller
2017-05-02 8:45 ` Andy Shevchenko
2017-05-02 14:42 ` David Miller
2017-05-01 2:29 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VcitfXWzUsUDthAXp97yjQQnEGND7eqSH-AFRVjH6pYDg@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=Ariel.Elior@cavium.com \
--cc=Yuval.Mintz@cavium.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).