From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Kalle Valo <kvalo@kernel.org>
Cc: duoming@zju.edu.cn,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Amitkumar Karwar <amitkarwar@gmail.com>,
Ganapathi Bhat <ganapathi017@gmail.com>,
Sharvari Harisangam <sharvari.harisangam@nxp.com>,
Xinming Hu <huxinming820@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
"open list:TI WILINK WIRELES..." <linux-wireless@vger.kernel.org>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net] net: wireless: marvell: mwifiex: fix sleep in atomic context bugs
Date: Fri, 20 May 2022 18:58:04 +0200 [thread overview]
Message-ID: <CAHp75Vd8om_5sC8LDcnRH1oi6pGTmL6AVBrpieZe3HepOXnoGw@mail.gmail.com> (raw)
In-Reply-To: <877d6h37c9.fsf@kernel.org>
On Thu, May 19, 2022 at 5:44 PM Kalle Valo <kvalo@kernel.org> wrote:
> duoming@zju.edu.cn writes:
> > On Thu, 19 May 2022 13:27:07 +0300 Kalle Valo wrote:
...
> >> > Fixes: f5ecd02a8b20 ("mwifiex: device dump support for usb interface")
> >> > Signed-off-by: Duoming Zhou <duoming@zju.edu.cn>
> >>
> >> Have you tested this on real hardware? Or is this just a theoretical
> >> fix?
> >
> > This is a theoretical fix. I don't have the real hardware.
>
> For such patches clearly document that in the commit log, for example
> something like "Compile tested only."
It seems I even missed this part... :-(
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-05-20 16:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-19 10:16 [PATCH net] net: wireless: marvell: mwifiex: fix sleep in atomic context bugs Duoming Zhou
2022-05-19 10:27 ` Kalle Valo
2022-05-19 11:36 ` duoming
2022-05-19 14:49 ` Kalle Valo
2022-05-20 16:58 ` Andy Shevchenko [this message]
2022-05-19 11:55 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75Vd8om_5sC8LDcnRH1oi6pGTmL6AVBrpieZe3HepOXnoGw@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=amitkarwar@gmail.com \
--cc=davem@davemloft.net \
--cc=duoming@zju.edu.cn \
--cc=edumazet@google.com \
--cc=ganapathi017@gmail.com \
--cc=huxinming820@gmail.com \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sharvari.harisangam@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).