From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Niklas Cassel <niklas.cassel@axis.com>
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
Niklas Cassel <niklass@axis.com>, netdev <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next] net: stmmac: use correct pointer when printing normal descriptor ring
Date: Sun, 28 May 2017 00:59:37 +0300 [thread overview]
Message-ID: <CAHp75VfwEGZ9m1_h=JSq4zmX0wy7Qgd-1uSVy3R0KfcSX09p1A@mail.gmail.com> (raw)
In-Reply-To: <20170509165202.19023-1-niklass@axis.com>
On Tue, May 9, 2017 at 7:52 PM, Niklas Cassel <niklas.cassel@axis.com> wrote:
> From: Niklas Cassel <niklas.cassel@axis.com>
Commit message?
> seq_printf(seq, "%d [0x%x]: 0x%x 0x%x 0x%x 0x%x\n",
> - i, (unsigned int)virt_to_phys(ep),
> + i, (unsigned int)virt_to_phys(p),
There is should not be casting. Pointer might be 64-bit, thus %pap
must be used instead with a reference to the physical address.
> le32_to_cpu(p->des0), le32_to_cpu(p->des1),
> le32_to_cpu(p->des2), le32_to_cpu(p->des3));
> p++;
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2017-05-27 21:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-09 16:52 [PATCH net-next] net: stmmac: use correct pointer when printing normal descriptor ring Niklas Cassel
2017-05-27 21:59 ` Andy Shevchenko [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-05-15 8:56 Niklas Cassel
2017-05-15 14:02 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VfwEGZ9m1_h=JSq4zmX0wy7Qgd-1uSVy3R0KfcSX09p1A@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=alexandre.torgue@st.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=niklas.cassel@axis.com \
--cc=niklass@axis.com \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).