From: Eyal Birger <eyal.birger@gmail.com>
To: Martin KaFai Lau <martin.lau@linux.dev>
Cc: netdev@vger.kernel.org, bpf@vger.kernel.org,
linux-kselftest@vger.kernel.org, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
steffen.klassert@secunet.com, herbert@gondor.apana.org.au,
andrii@kernel.org, daniel@iogearbox.net,
nicolas.dichtel@6wind.com, razor@blackwall.org, mykolal@fb.com,
ast@kernel.org, song@kernel.org, yhs@fb.com,
john.fastabend@gmail.com, kpsingh@kernel.org, sdf@google.com,
haoluo@google.com, jolsa@kernel.org, shuah@kernel.org
Subject: Re: [PATCH ipsec-next,v2 3/3] selftests/bpf: add xfrm_info tests
Date: Thu, 1 Dec 2022 15:33:40 +0200 [thread overview]
Message-ID: <CAHsH6Gt3tRqGDG5ssGZMzxB+1xToFk5-RZn319KOnB4cLnC11Q@mail.gmail.com> (raw)
In-Reply-To: <add18909-4e5c-26e7-a96d-5715aba18219@linux.dev>
Hi Martin,
On Thu, Dec 1, 2022 at 9:33 AM Martin KaFai Lau <martin.lau@linux.dev> wrote:
>
> On 11/30/22 9:34 PM, Eyal Birger wrote:
> >>> +static int probe_iproute2(void)
> >>> +{
> >>> + if (SYS_NOFAIL("ip link add type xfrm help 2>&1 | "
> >>> + "grep external > /dev/null")) {
> >>> + fprintf(stdout, "%s:SKIP: iproute2 with xfrm external support needed for this test\n", __func__);
> >>
> >> Unfortunately, the BPF CI iproute2 does not have this support also :(
> >> I am worry it will just stay SKIP for some time and rot. Can you try to
> >> directly use netlink here?
> >
> > Yeah, I wasn't sure if adding a libmnl (or alternative) dependency
> > was ok here, and also didn't want to copy all that nl logic here.
> > So I figured it would get there eventually.
> >
> > I noticed libmnl is used by the nf tests, so maybe its inclusion isn't too
> > bad. Unless there's a better approach.
>
> I wasn't thinking about including the libmnl. I am thinking about something
> lightweight like the bpf_tc_hook_create() used in this test.
> bpf_tc_hook_create() is in libbpf's netlink.c. Not sure if this netlink
> link-add helper belongs to libbpf though, so it will be better just stay here in
> this selftest for now. If it is too complicated without libmnl, leave it as
> SKIP for now is an option and I will try to run it manually first with a newer
> iproute2.
Looks like it doesn't turn out too bad imho without libmnl, basically
needs a few rtattr helpers.
Will do it that way in v3.
Eyal.
next prev parent reply other threads:[~2022-12-01 13:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-29 13:20 [PATCH ipsec-next,v2 0/3] xfrm: interface: Add unstable helpers for XFRM metadata Eyal Birger
2022-11-29 13:20 ` [PATCH ipsec-next,v2 1/3] xfrm: interface: rename xfrm_interface.c to xfrm_interface_core.c Eyal Birger
2022-11-29 13:20 ` [PATCH ipsec-next,v2 2/3] xfrm: interface: Add unstable helpers for setting/getting XFRM metadata from TC-BPF Eyal Birger
2022-11-30 18:14 ` Martin KaFai Lau
2022-12-01 5:55 ` Eyal Birger
2022-12-01 13:30 ` Eyal Birger
2022-12-01 20:18 ` Martin KaFai Lau
2022-12-01 20:47 ` Eyal Birger
2022-12-01 20:21 ` Martin KaFai Lau
2022-11-29 13:20 ` [PATCH ipsec-next,v2 3/3] selftests/bpf: add xfrm_info tests Eyal Birger
2022-11-30 18:41 ` Martin KaFai Lau
2022-11-30 18:48 ` Martin KaFai Lau
2022-12-01 5:34 ` Eyal Birger
2022-12-01 7:33 ` Martin KaFai Lau
2022-12-01 13:33 ` Eyal Birger [this message]
2022-12-01 20:26 ` Martin KaFai Lau
2022-12-01 20:48 ` Eyal Birger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHsH6Gt3tRqGDG5ssGZMzxB+1xToFk5-RZn319KOnB4cLnC11Q@mail.gmail.com \
--to=eyal.birger@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=haoluo@google.com \
--cc=herbert@gondor.apana.org.au \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=mykolal@fb.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=sdf@google.com \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=steffen.klassert@secunet.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).