From: Pieter <vtpieter@gmail.com>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: devicetree@vger.kernel.org, woojung.huh@microchip.com,
UNGLinuxDriver@microchip.com, netdev@vger.kernel.org,
Pieter Van Trappen <pieter.van.trappen@cern.ch>
Subject: Re: [PATCH 2/4] net: dsa: microchip: ksz8795: add Wake on LAN support
Date: Sat, 20 Jul 2024 14:44:10 +0200 [thread overview]
Message-ID: <CAHvy4ArOx2MhMmrgeosPbr8NLE6Kf=wWuL23+g-+2=Uf9UaFtQ@mail.gmail.com> (raw)
In-Reply-To: <ZppuQo9sGdYJWgBQ@pengutronix.de>
Le ven. 19 juil. 2024 à 15:46, Oleksij Rempel
<o.rempel@pengutronix.de> a écrit :
>
> Hi Pieter,
>
> If I see it correctly, the only difference between KSZ9477 and KSZ8795
> code is the register access. Even bit offsets are identical. I do not
> think indirect register access is good justification for duplication
> this amount of code.
Hi Oleksij, thanks for the review! I guess you're right - I must have
gone too quickly for the easy way out. There's actually one additional
register access for KSZ8795 but it should be possible to get around
this as well. I'll work on it but it might take me a few weeks to get
this ready. Would be great if you still have a KSZ9477 family board
around to validate.
Cheers, Pieter
next prev parent reply other threads:[~2024-07-20 12:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-17 19:37 [PATCH 0/4] net: dsa: microchip: ksz8795: add Wake on LAN support vtpieter
2024-07-17 19:37 ` [PATCH 1/4] dt-bindings: net: dsa: microchip: add microchip,pme-active-high flag vtpieter
2024-07-17 19:37 ` [PATCH 2/4] net: dsa: microchip: ksz8795: add Wake on LAN support vtpieter
2024-07-17 19:37 ` [PATCH 3/4] net: dsa: microchip: check erratum workaround through indirect register read vtpieter
2024-07-17 19:37 ` [PATCH 4/4] net: dsa: microchip: ksz9477: correct description of WoL functions vtpieter
2024-07-19 13:52 ` Oleksij Rempel
2024-07-18 2:24 ` [PATCH 3/4] net: dsa: microchip: check erratum workaround through indirect register read Andrew Lunn
2024-07-18 13:45 ` Pieter
2024-07-19 13:46 ` [PATCH 2/4] net: dsa: microchip: ksz8795: add Wake on LAN support Oleksij Rempel
2024-07-20 12:44 ` Pieter [this message]
2024-07-19 12:36 ` [PATCH 1/4] dt-bindings: net: dsa: microchip: add microchip,pme-active-high flag Oleksij Rempel
2024-07-23 2:42 ` Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHvy4ArOx2MhMmrgeosPbr8NLE6Kf=wWuL23+g-+2=Uf9UaFtQ@mail.gmail.com' \
--to=vtpieter@gmail.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pieter.van.trappen@cern.ch \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).