From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 23906378815 for ; Thu, 26 Mar 2026 09:44:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774518297; cv=none; b=rd2PcimUQ1N+Az4qN1ocLDC27BzT/vaAqp7lEAMLH9C3UeQqQzDsn/Wtz9wD9UVqGFWiIn2iUyKofHAZjKbVVnfvdu2Vjo6EOsr253vG9BTjvTFty5N5XCy3AfuEwx5T0dxgZrPtAj1mtbT8m811XIYID4cOdV90/dH5WeTNV2M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774518297; c=relaxed/simple; bh=SwK+xrVkILMxAk+bQOoYhEd8oWiRnuLGcIQjwqqEHC8=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=Z/iOCz1kTanOC5OPGcLFemjNLSLbbVnWDodf4VJgTlFAk20lxpZtH+krhBsqYapNhs1+sHXCAc6ohHFnaGnHpKBygPrvlyJIOr+SoFSu9vpdkAjYUPSs4oOUYY4fg2zitBC3dLwqYp//KCEwsALgydbEs9+PDo5oScb7BrFCtJI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=qk4SWL0B; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="qk4SWL0B" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B08C7C2BCB2 for ; Thu, 26 Mar 2026 09:44:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774518296; bh=SwK+xrVkILMxAk+bQOoYhEd8oWiRnuLGcIQjwqqEHC8=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=qk4SWL0BS2oZHiDUvBW/bAxeHx1BXEOWfGKaMh4imMYuvXydMJQxKaiYS4vQGqpRA KJl5vGs3KFn0zqG0hGubfZQ+ieLSVRDmDy4ZSjU3fJsf8ou+XPp7UrwCZQjAx4+Fdu ZZAKnISxQ6mTuselNzsg55K0hHAUs+POyB9XWBxXtVgER803OVVJnlcmKnCqjdp2Yk UqDAEyiskT00D6jK1ygmtILaGQQsgpSA65xFiHQpIs2ARMLeNmYQHUHzujjwsiSvdM 2RgAAohQUjLJ0+9FITXef3rwVKFdyy8oNfMnF589By3bfREuGCIqEb+lyyzZQ2U7dh bivJsHrC9DzCg== Received: by mail-qt1-f179.google.com with SMTP id d75a77b69052e-505a1789a27so4395311cf.3 for ; Thu, 26 Mar 2026 02:44:56 -0700 (PDT) X-Gm-Message-State: AOJu0YwxiqKbeuK7ozWhC0OkKTcPH5ammqumiaVcN0WxZ9d6MA/HN1B6 KXTbOP5gExDZqP+QRhsfbK/H0H6pE+Z3XO4wov6+YSgLDfKKULRG8tzAX6t1kd1e8rKiF34VqLq NC2JdfnEAvS/yyyOB7/Bex7UqxBX9/IQ= X-Received: by 2002:ac8:5a8f:0:b0:50b:2d93:97b2 with SMTP id d75a77b69052e-50b80d1aa89mr96117381cf.23.1774518295241; Thu, 26 Mar 2026 02:44:55 -0700 (PDT) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20260325145022.2607545-1-bjorn@kernel.org> <20260325145022.2607545-10-bjorn@kernel.org> In-Reply-To: From: =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= Date: Thu, 26 Mar 2026 10:44:44 +0100 X-Gmail-Original-Message-ID: X-Gm-Features: AQROBzBqP5kFyddHgaLVB_TU1Jo_YEll9H_X4UmnFm7jfjc29GXNVciOBMmOjNg Message-ID: Subject: Re: [PATCH net-next v2 09/12] selftests: drv-net: Add MAC loopback netdevsim test To: Breno Leitao Cc: netdev@vger.kernel.org, "David S. Miller" , Andrew Lunn , Donald Hunter , Eric Dumazet , Jakub Kicinski , Maxime Chevallier , Naveen Mamindlapalli , Paolo Abeni , Simon Horman , Danielle Ratson , Hariprasad Kelam , Ido Schimmel , Kory Maincent , Leon Romanovsky , Michael Chan , Oleksij Rempel , Pavan Chebbi , Piergiorgio Beruto , Russell King , Saeed Mahameed , Shuah Khan , Tariq Toukan , Willem de Bruijn , Kees Cook , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-rdma@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Breno! On Thu, 26 Mar 2026 at 10:33, Breno Leitao wrote: > > On Wed, Mar 25, 2026 at 03:50:16PM +0100, Bj=C3=B6rn T=C3=B6pel wrote: > > > +def _dfs_write_u32(cfg, path, val): > > + with open(os.path.join(_nsim_dfs_path(cfg), path), "w", > > + encoding=3D"utf-8") as f: > > + f.write(str(val)) > > This function doesn't seem to be called, right? Indeed -- another leftover! Thank you! > > +def main() -> None: > > + """Run netdevsim loopback tests.""" > > + with NetDrvEnv(__file__) as cfg: > > + cfg.ethnl =3D EthtoolFamily() > > Given some functions above assume this is nsim, should you call > cfg.require_nsim() ? Yeah, or directly from NetDrvEnv() statement above! Good point! Will fix! Bj=C3=B6rn