From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lorenzo Bianconi Subject: Re: [PATCH v2 net-next 3/5] l2tp: remove l2specific_len dependency in l2tp_core Date: Mon, 15 Jan 2018 19:43:18 +0100 Message-ID: References: <7e4c380b853e31d6ec4b25db4c9812efa37b108c.1515940731.git.lorenzo.bianconi@redhat.com> <20180115182000.GB1422@alphalink.fr> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Cc: "David S. Miller" , netdev@vger.kernel.org, James Chapman To: Guillaume Nault Return-path: Received: from mail-yw0-f181.google.com ([209.85.161.181]:44629 "EHLO mail-yw0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750916AbeAOSnT (ORCPT ); Mon, 15 Jan 2018 13:43:19 -0500 Received: by mail-yw0-f181.google.com with SMTP id x62so5773581ywg.11 for ; Mon, 15 Jan 2018 10:43:19 -0800 (PST) In-Reply-To: <20180115182000.GB1422@alphalink.fr> Sender: netdev-owner@vger.kernel.org List-ID: > On Sun, Jan 14, 2018 at 03:50:56PM +0100, Lorenzo Bianconi wrote: >> --- a/net/l2tp/l2tp_core.h >> +++ b/net/l2tp/l2tp_core.h >> @@ -302,6 +302,17 @@ static inline void l2tp_session_dec_refcount(struct l2tp_session *session) >> l2tp_session_free(session); >> } >> >> +static inline int l2tp_get_l2specific_len(struct l2tp_session *session) >> +{ >> + switch (session->l2specific_type) { >> + case L2TP_L2SPECTYPE_NONE: >> + return 0; >> + case L2TP_L2SPECTYPE_DEFAULT: >> + default: >> + return 4; >> + } >> +} >> > The data path only compares ->l2specific_type to L2SPECTYPE_DEFAULT and > treats any other value as L2SPECTYPE_NONE. Therefore, we should keep > this logic here and return 0 for unknown types. The data path only compares l2specific_type to L2SPECTYPE_DEFAULT since in the other supported case (L2SPECTYPE_NONE) there is no action required. Moreover L2SPECTYPE_DEFAULT is default configured value if the user does not provide any value for l2specific_type so there are no 'unknown' types and I thought L2TP_L2SPECTYPE_DEFAULT was a better choice for default value