From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F6FEC76186 for ; Wed, 17 Jul 2019 09:08:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3A657217D9 for ; Wed, 17 Jul 2019 09:08:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b="ARPF8ysR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730664AbfGQJIL (ORCPT ); Wed, 17 Jul 2019 05:08:11 -0400 Received: from mail-lf1-f68.google.com ([209.85.167.68]:44877 "EHLO mail-lf1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725980AbfGQJIL (ORCPT ); Wed, 17 Jul 2019 05:08:11 -0400 Received: by mail-lf1-f68.google.com with SMTP id r15so10978172lfm.11 for ; Wed, 17 Jul 2019 02:08:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=k7UdXNTU/Lcm5T+73Mu9Lk3fJTqZdL2ygB2hxg/bvs0=; b=ARPF8ysRS2qme660bnfPo9Sf6dUPUtYkSPR39gw+zuIoL7NZtNifRCF1SXDGFunevB uB8IuWYM1iKac8uIBfwlUQMiC8nlsO8DxhVUztZfWDxGTVv0AP3VA2gNewP/19w1a1LW +DLcKtE6254Ku0JHNY1kGsvrzSV9XAaFc8P93ruj/1XfqkiXTeiLARokVfXAhvHNhUAp oU/deRwXfo0vLuXt+HfYNfQX609LSRr1XRlJKA2ojTpGANWQaz3QzdMP8uvHrMD7iW8j FKIENDnCF1zDqRZvKhZ/RJljDTl2EmbDSDS67+xcSz06fthg9HXQPPGsqQ0bzxxY3PqD Ki/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=k7UdXNTU/Lcm5T+73Mu9Lk3fJTqZdL2ygB2hxg/bvs0=; b=ZY7P3HrUQ1tmk+kpRUmkHXkEc17mhdLiTOnubff1DTCan9hx1xAmGsGJd4S7tckUtw VYDD3mtuZ8d5OrJ0sFKX1mwmLIuN2lSbAesNeP4P224gndnO2tC+QkqjEH+EqBv0UCw6 zGPRZcySt/eesJeCDlvGnMCaRSAJAgkUdVpVjCz4Ae5kLkXg7qwWdx7M7ChEcpi27Ekh m1eoR+RU/cbIlb+RZF/sf6/g3t8rbAXJEZ3FDxbgUp6NzLKzMbLzke4PXjhTvbZPTqRw IPjak37rkFEqtTGU1Y3FrfSdHHElPSB2HUJeb09wraCPu0EZbIN2Z7kiF76jmCHanu1U aNzw== X-Gm-Message-State: APjAAAUEITN6F3sRslsMsWR1ais3RxWUxr4kye8QAG87HKST6sLJ5Sra 3j62LGJ61tglrBxBHpM2bEiyTEtozIur6DU1m2N+cA== X-Google-Smtp-Source: APXvYqyUa5Y6gp/AOOmOhWXG0woHIHFHQ/pw+MgFTpkHnca8dVBQpSXO7UwrMm763Jwm92ZWv/5Cb/402QneMPo+DUs= X-Received: by 2002:ac2:4644:: with SMTP id s4mr17067571lfo.158.1563354489475; Wed, 17 Jul 2019 02:08:09 -0700 (PDT) MIME-Version: 1.0 References: <1558611952-13295-1-git-send-email-yash.shah@sifive.com> <1558611952-13295-2-git-send-email-yash.shah@sifive.com> In-Reply-To: From: Yash Shah Date: Wed, 17 Jul 2019 14:37:33 +0530 Message-ID: Subject: Re: [PATCH 1/2] net/macb: bindings doc: add sifive fu540-c000 binding To: Nicolas Ferre Cc: Rob Herring , David Miller , netdev , "linux-kernel@vger.kernel.org List" , linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, Mark Rutland , Palmer Dabbelt , Albert Ou , =?UTF-8?Q?Petr_=C5=A0tetiar?= , Paul Walmsley , Sachin Ghadi Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Jun 24, 2019 at 9:08 PM wrote: > > On 23/05/2019 at 22:50, Rob Herring wrote: > > On Thu, May 23, 2019 at 6:46 AM Yash Shah wrote: > >> > >> Add the compatibility string documentation for SiFive FU540-C0000 > >> interface. > >> On the FU540, this driver also needs to read and write registers in a > >> management IP block that monitors or drives boundary signals for the > >> GEMGXL IP block that are not directly mapped to GEMGXL registers. > >> Therefore, add additional range to "reg" property for SiFive GEMGXL > >> management IP registers. > >> > >> Signed-off-by: Yash Shah > >> --- > >> Documentation/devicetree/bindings/net/macb.txt | 3 +++ > >> 1 file changed, 3 insertions(+) > >> > >> diff --git a/Documentation/devicetree/bindings/net/macb.txt b/Documentation/devicetree/bindings/net/macb.txt > >> index 9c5e944..91a2a66 100644 > >> --- a/Documentation/devicetree/bindings/net/macb.txt > >> +++ b/Documentation/devicetree/bindings/net/macb.txt > >> @@ -4,6 +4,7 @@ Required properties: > >> - compatible: Should be "cdns,[-]{macb|gem}" > >> Use "cdns,at91rm9200-emac" Atmel at91rm9200 SoC. > >> Use "cdns,at91sam9260-macb" for Atmel at91sam9 SoCs. > >> + Use "cdns,fu540-macb" for SiFive FU540-C000 SoC. > > > > This pattern that Atmel started isn't really correct. The vendor > > prefix here should be sifive. 'cdns' would be appropriate for a > > fallback. > > Ok, we missed this for the sam9x60 SoC that we added recently then. > > Anyway a little too late, coming back to this machine, and talking to > Yash, isn't "sifive,fu540-c000-macb" more specific and a better match > for being future proof? I would advice for the most specific possible > with other compatible strings on the same line in the DT, like: > > "sifive,fu540-c000-macb", "sifive,fu540-macb" > Yes, I agree that "sifive,fu540-c000-macb" is a better match. > Moreover, is it really a "macb" or a "gem" type of interface from > Cadence? Not a big deal, but just to discuss the topic to the bone... I believe it should be "gem". I will plan to submit the patch for these changes. Thanks for pointing it out. - Yash > > Note that I'm fine if you consider that what you have in net-next new is > correct. > > Regards, > Nicolas > > >> Use "cdns,sam9x60-macb" for Microchip sam9x60 SoC. > >> Use "cdns,np4-macb" for NP4 SoC devices. > >> Use "cdns,at32ap7000-macb" for other 10/100 usage or use the generic form: "cdns,macb". > >> @@ -17,6 +18,8 @@ Required properties: > >> Use "cdns,zynqmp-gem" for Zynq Ultrascale+ MPSoC. > >> Or the generic form: "cdns,emac". > >> - reg: Address and length of the register set for the device > >> + For "cdns,fu540-macb", second range is required to specify the > >> + address and length of the registers for GEMGXL Management block. > >> - interrupts: Should contain macb interrupt > >> - phy-mode: See ethernet.txt file in the same directory. > >> - clock-names: Tuple listing input clock names. > >> -- > >> 1.9.1 > >> > > > > > -- > Nicolas Ferre