From: Rayagond Kokatanur <rayagond@vayavyalabs.com>
To: Joao Pinto <Joao.Pinto@synopsys.com>
Cc: David Miller <davem@davemloft.net>, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH] net: stmicro: fix LS field mask in EEE configuration
Date: Mon, 23 Jan 2017 11:01:08 +0530 [thread overview]
Message-ID: <CAJ3bTp5hcodw9C5Rs6OowFg4D28e4AnseMXG8agxs+0chTnW9w@mail.gmail.com> (raw)
In-Reply-To: <ed690f703a3c82193737f1a9813dff8b1ff403dd.1484927665.git.jpinto@synopsys.com>
Acked-by:Rayagond Kokatanur <rayagond@vayavyalabs.com>
On Fri, Jan 20, 2017 at 9:30 PM, Joao Pinto <Joao.Pinto@synopsys.com> wrote:
> This patch fixes the LS mask when setting EEE timer.
> LS field is 10 bits long and not 11 as currently.
>
> Signed-off-by: Joao Pinto <jpinto@synopsys.com>
> Reported-By: Rayagond Kokatanur <rayagond@vayavyalabs.com>
> ---
> drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c b/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c
> index 834f40f..202216c 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c
> @@ -184,7 +184,7 @@ static void dwmac4_set_eee_pls(struct mac_device_info *hw, int link)
> static void dwmac4_set_eee_timer(struct mac_device_info *hw, int ls, int tw)
> {
> void __iomem *ioaddr = hw->pcsr;
> - int value = ((tw & 0xffff)) | ((ls & 0x7ff) << 16);
> + int value = ((tw & 0xffff)) | ((ls & 0x3ff) << 16);
>
> /* Program the timers in the LPI timer control register:
> * LS: minimum time (ms) for which the link
> --
> 2.9.3
>
--
wwr
Rayagond
prev parent reply other threads:[~2017-01-23 5:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-20 16:00 [PATCH] net: stmicro: fix LS field mask in EEE configuration Joao Pinto
2017-01-22 21:49 ` David Miller
2017-01-23 10:17 ` Joao Pinto
2017-01-23 5:31 ` Rayagond Kokatanur [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJ3bTp5hcodw9C5Rs6OowFg4D28e4AnseMXG8agxs+0chTnW9w@mail.gmail.com \
--to=rayagond@vayavyalabs.com \
--cc=Joao.Pinto@synopsys.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).