From: Rayagond K <rayagond@vayavyalabs.com>
To: Richard Cochran <richardcochran@gmail.com>
Cc: Giuseppe CAVALLARO <peppe.cavallaro@st.com>,
netdev@vger.kernel.org, bh74.an@samsung.com
Subject: Re: [net-next.git 4/9] stmmac: add the support for PTP hw clock driver
Date: Tue, 12 Mar 2013 10:13:17 +0530 [thread overview]
Message-ID: <CAJ3bTp76BX-nbk5E_QVyx--EPAWbf3JtORVTbwjcd0skndzbKg@mail.gmail.com> (raw)
In-Reply-To: <20130311185536.GA2409@netboy.at.omicron.at>
On Tue, Mar 12, 2013 at 12:25 AM, Richard Cochran
<richardcochran@gmail.com> wrote:
> On Sun, Mar 10, 2013 at 08:37:24PM +0530, Rayagond K wrote:
>> On Sun, Mar 10, 2013 at 5:40 PM, Richard Cochran <richardcochran@gmail.com>wrote:
>
>> > Don't you need locking here to protect against concurrent callers of
>> > config_addend?
>> >
>>
>> Yes we need locking here too, will add it.
>>
>> But I can see no locking in this function in other two driver'e
>> ppt_ixp46x.c and gianfar_ptp.c. So I just followed these two driver.
>
> Those two drivers don't need locking, because setting the addend
> register is a single 32 bit write operation in both cases.
>
> In your driver, setting the addend involves a sequence of writes and
> reads, in addition to polling a status bit, so you do need to
> serialize access to those registers.
Okay, will take lock in our driver. Thank you.
>
> Thanks,
> Richard
next prev parent reply other threads:[~2013-03-12 4:43 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-07 10:50 [net-next.git 0/9] stmmac: update to March_2013 (adding PTP & RGMII/SGMII) Giuseppe CAVALLARO
2013-03-07 10:50 ` [net-next.git 1/9] stmmac: add tx_skbuff_dma to save descriptors used by PTP Giuseppe CAVALLARO
2013-03-07 10:50 ` [net-next.git 2/9] stmmac: add IEEE 1588-2002 PTP support Giuseppe CAVALLARO
2013-03-08 6:34 ` Richard Cochran
2013-03-08 7:02 ` Giuseppe CAVALLARO
2013-03-08 7:51 ` Rayagond K
2013-03-10 12:25 ` Richard Cochran
2013-03-10 12:40 ` Richard Cochran
2013-03-11 6:35 ` Giuseppe CAVALLARO
[not found] ` <CAJ3bTp6tQ4L0vya9-eO0E+19Wk74uNJonbA9hqc+fgN77dcjOQ@mail.gmail.com>
2013-03-10 12:31 ` Richard Cochran
2013-03-07 10:50 ` [net-next.git 3/9] stmmac: support extend descriptors Giuseppe CAVALLARO
2013-03-07 10:50 ` [net-next.git 4/9] stmmac: add the support for PTP hw clock driver Giuseppe CAVALLARO
2013-03-10 12:10 ` Richard Cochran
[not found] ` <CAJ3bTp7n-Y6TYrhDMe58fALtX5O34qifO9khWYXpo-OwnrRKiQ@mail.gmail.com>
2013-03-11 18:55 ` Richard Cochran
2013-03-12 4:43 ` Rayagond K [this message]
2013-03-07 10:50 ` [net-next.git 5/9] stmmac: add IEEE 1588-2008 PTP V2 support Giuseppe CAVALLARO
2013-03-07 10:50 ` [net-next.git 6/9] stmmac: add missing supported filters to get_ts_info Giuseppe CAVALLARO
2013-03-10 12:36 ` Richard Cochran
2013-03-11 6:39 ` Giuseppe CAVALLARO
2013-03-07 10:50 ` [net-next.git 7/9] stmmac: start adding pcs and rgmii core irq Giuseppe CAVALLARO
2013-03-07 10:50 ` [net-next.git 8/9] stmmac: initial support to manage pcs modes Giuseppe CAVALLARO
2013-03-07 10:50 ` [net-next.git 9/9] stmmac: update the Doc and Version (PTP+SGMII) Giuseppe CAVALLARO
2013-03-07 20:34 ` [net-next.git 0/9] stmmac: update to March_2013 (adding PTP & RGMII/SGMII) David Miller
2013-03-08 7:16 ` Giuseppe CAVALLARO
2013-03-08 16:22 ` David Miller
2013-03-11 7:11 ` Giuseppe CAVALLARO
2013-03-22 14:27 ` Giuseppe CAVALLARO
2013-03-08 6:04 ` Richard Cochran
2013-03-08 6:39 ` Giuseppe CAVALLARO
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJ3bTp76BX-nbk5E_QVyx--EPAWbf3JtORVTbwjcd0skndzbKg@mail.gmail.com \
--to=rayagond@vayavyalabs.com \
--cc=bh74.an@samsung.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).