From: Or Gerlitz <gerlitz.or@gmail.com>
To: Amir Vadai <amirv@mellanox.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Linux Netdev List <netdev@vger.kernel.org>,
Or Gerlitz <ogerlitz@mellanox.com>, Tal Alon <talal@mellanox.com>,
Ben Hutchings <ben@decadent.org.uk>
Subject: Re: [PATCH net 0/2] net/ethtool, mlx4_en: RSS hash function setting fixes
Date: Sun, 26 Apr 2015 20:18:28 +0300 [thread overview]
Message-ID: <CAJ3xEMh2fbToSmRkx77VrppTfxFNKa17TpewbjZzyWrzU6fisA@mail.gmail.com> (raw)
In-Reply-To: <1430058966-24046-1-git-send-email-amirv@mellanox.com>
On Sun, Apr 26, 2015 at 5:36 PM, Amir Vadai <amirv@mellanox.com> wrote:
> Hi Dave,
>
> This small patchset fixes a small issue in the ethtool User/kernel API.
>
> Hash function is represented as an eight bit field, every bit represents a
> function. Currently possible values are: 1 for Toeplitz and 2 for XOR.
> This commit changes the representation from bit flags into a value. Because
> only one hash function will be used at a time, there is no sense using bit
> flags for it.
> Since today only 2 functions are supported, and there is no user space ethtool
> that supports this feature, we can switch into values without causing any
> backward compatibility issues.
>
> After this patchset is applied, I will send the user space patch.
>
> In this occasion I added a missing validation to the hash function value.
>
> This patchset was applied and tested over commit 2ea2f62 ("net: fix crash in build_skb()")
>
> Please push this patchset to stable 3.19.y in which those two issues were introduced.
and 4.0.y too I guess?
next prev parent reply other threads:[~2015-04-26 17:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-26 14:36 [PATCH net 0/2] net/ethtool, mlx4_en: RSS hash function setting fixes Amir Vadai
2015-04-26 14:36 ` [PATCH net 1/2] ethtool: Use values instead of bit flags for RSS hash function Amir Vadai
2015-04-26 14:36 ` [PATCH net 2/2] net/mlx4_en: Prevent setting invalid " Amir Vadai
2015-04-26 17:18 ` Or Gerlitz [this message]
2015-04-27 3:02 ` [PATCH net 0/2] net/ethtool, mlx4_en: RSS hash function setting fixes David Miller
2015-04-27 10:34 ` Amir Vadai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJ3xEMh2fbToSmRkx77VrppTfxFNKa17TpewbjZzyWrzU6fisA@mail.gmail.com \
--to=gerlitz.or@gmail.com \
--cc=amirv@mellanox.com \
--cc=ben@decadent.org.uk \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=talal@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).