netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Or Gerlitz <gerlitz.or@gmail.com>
To: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: David Miller <davem@davemloft.net>,
	Paul Greenwalt <paul.greenwalt@intel.com>,
	Linux Netdev List <netdev@vger.kernel.org>,
	"nhorman@redhat.com" <nhorman@redhat.com>,
	"sassmann@redhat.com" <sassmann@redhat.com>,
	"jogreene@redhat.com" <jogreene@redhat.com>
Subject: Re: [net-next v2 6/6] ixgbe: Add malicious driver detection support
Date: Tue, 27 Jun 2017 12:07:43 +0300	[thread overview]
Message-ID: <CAJ3xEMiEjGDUatUv47wNTfYPfCVo62+Jjs-xFU3ccN0iJm-5Gg@mail.gmail.com> (raw)
In-Reply-To: <20170627085131.9831-7-jeffrey.t.kirsher@intel.com>

On Tue, Jun 27, 2017 at 11:51 AM, Jeff Kirsher
<jeffrey.t.kirsher@intel.com> wrote:
> From: Paul Greenwalt <paul.greenwalt@intel.com>
>
> Add malicious driver detection (MDD) support for X550, X550em_a,
> and X550em_x devices.
>
> MDD is a hardware SR-IOV security feature which the driver enables by
> default, but can be controlled on|off by ethtool set-priv-flags

wait, we have the trusted vf concept, which you implement
(ixgbe_ndo_set_vf_trust)
so you can enable by default for all vfs and disable it for trusted
ones, why create
an ixgbe special config knob? IMHO we should max all possible efforts to avoid
priv ethtool flags usage.


Or.

  reply	other threads:[~2017-06-27  9:07 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-27  8:51 [net-next v2 0/6][pull request] 10GbE Intel Wired LAN Driver Updates 2017-06-27 Jeff Kirsher
2017-06-27  8:51 ` [net-next v2 1/6] ixgbe: Ensure MAC filter was added before setting MACVLAN Jeff Kirsher
2017-06-27  8:51 ` [net-next v2 2/6] ixgbe: Enable LASI interrupts for X552 devices Jeff Kirsher
2017-06-27  8:51 ` [net-next v2 3/6] ixgbe: Update NW_MNG_IF_SEL support for X553 Jeff Kirsher
2017-06-27  8:51 ` [net-next v2 4/6] ixgbe: Do not support flow control autonegotiation " Jeff Kirsher
2017-06-27  8:51 ` [net-next v2 5/6] ixgbe: Disable flow control for XFI Jeff Kirsher
2017-06-27  8:51 ` [net-next v2 6/6] ixgbe: Add malicious driver detection support Jeff Kirsher
2017-06-27  9:07   ` Or Gerlitz [this message]
2017-06-27 20:59     ` Tantilov, Emil S
2017-06-27 21:07       ` Or Gerlitz
2017-06-27 22:14         ` Tantilov, Emil S
2017-06-28 14:28           ` Or Gerlitz
2017-06-29 18:28             ` David Miller
2017-06-29 21:19               ` Tantilov, Emil S

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJ3xEMiEjGDUatUv47wNTfYPfCVo62+Jjs-xFU3ccN0iJm-5Gg@mail.gmail.com \
    --to=gerlitz.or@gmail.com \
    --cc=davem@davemloft.net \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=jogreene@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=nhorman@redhat.com \
    --cc=paul.greenwalt@intel.com \
    --cc=sassmann@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).